feat(form): apply tokens for form, form control, radio, check#6135
feat(form): apply tokens for form, form control, radio, check#6135mcoker merged 8 commits intopatternfly:v6from
Conversation
|
Preview: https://patternfly-pr-6135.surge.sh A11y report: https://patternfly-pr-6135-a11y.surge.sh |
srambach
requested review from
a team,
mattnolting and
thatblindgeye
and removed request for
a team
srambach
changed the title
srambach
changed the title
| --#{$form}__group-label-help--hover--Color: var(--pf-t--global--icon--color--regular); | ||
| --#{$form}__group-label-help--focus--Color: var(--pf-t--global--icon--color--brand--hover); |
There was a problem hiding this comment.
Are these meant to be different? I see there's a comment about the help icon on the Figma, so wanted to check on these vars.
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Looks good. The only other thing is that the disabled FormControls are failing color contrast according to Firefox:
We could open a followup to resolve that if needed, unless it'd just involve updating something in Figma. cc @lboehling
|
I was using the icon color on-disabled instead of the text one - but they are the same, this was just a mistake, so it doesn't changed the contrast issue. I think we could move forward and tweak the token later. |
| display: grid; | ||
| gap: var(--#{$form}__group-control--Gap); |
There was a problem hiding this comment.
I'm not sure if we want to make this a grid layout by default? Currently you can place stuff in it and it will have a normal layout that you can modify. This will make any children grid items and be the same effectively as the .pf-m-stack modifier.
| } | ||
|
|
||
| .#{$form}__group-label-info { | ||
| margin-inline-start: var(--#{$form}__group-label-info--MarginLeft); |
There was a problem hiding this comment.
Did you mean to remove this? You still have the var, and without this declaration the text and info text touch
srambach
force-pushed
the
5706-new-new-form-controls-tokens
branch
from
6dcb8dc to
5dc2e38
Compare
|
🎉 This PR is included in version 6.0.0-alpha.46 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Note:
Input groups and number input aren't included here
This recreates PR #6071 for the new v6 branch
Fixes #6156