feat(SimpleList): apply tokens #6100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-pr-6100.surge.sh A11y report: https://patternfly-pr-6100-a11y.surge.sh |
mcoker
reviewed
Dec 6, 2023
mcoker
requested changes
Dec 6, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Looks awesome! Tested the .pf-m-link variation with a <button> and it looks like a link 👍 Left a few comments for review, lemme know if you have questions.
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just a couple questions below. Also, should the disabled styling be added still? Mainly wondering because if so then in the designs the background color shown for a disabled item would make the text difficult/impossible to read.
mcoker
approved these changes
Dec 8, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM other than the selector update on the component vars @thatblindgeye mentioned
Closed
kmcfaul
force-pushed
the
simplelist-penta
branch
from
256d56b to
89cba1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6099