feat(BackToTop): refactor with tokens by wise-king-sullyman · Pull Request #6085 · patternfly/patternfly

wise-king-sullyman · 2023-11-28T22:11:42Z

Closes #6084

Figma design for back to top

Convenience link: https://patternfly-pr-6085.surge.sh/components/back-to-top

patternfly-build · 2023-11-28T22:15:58Z

Preview: https://patternfly-pr-6085.surge.sh

A11y report: https://patternfly-pr-6085-a11y.surge.sh

mcoker

Looks good! Left a couple o' comments for review

mcoker · 2023-11-29T19:16:13Z

src/patternfly/components/BackToTop/back-to-top.scss

+  --#{$back-to-top}--c-button--PaddingRight: var(--pf-t--global--spacer--sm);
+  --#{$back-to-top}--c-button--PaddingBottom: var(--pf-t--global--spacer--xs);
+  --#{$back-to-top}--c-button--PaddingLeft: var(--pf-t--global--spacer--sm);
+  --#{$back-to-top}--c-button--BoxShadow: var(--pf-t--global--box-shadow--lg--bottom);


Looks like the design calls for /* light/global/shadow/small */

mcoker · 2023-11-29T19:27:02Z

src/patternfly/components/BackToTop/back-to-top.scss

+  --#{$back-to-top}--Bottom: var(--pf-t--global--spacer--lg);
+  --#{$back-to-top}--md--Bottom: var(--pf-t--global--spacer--2xl);
+  --#{$back-to-top}--c-button--FontSize: var(--pf-t--global--font--size--body--sm);
+  --#{$back-to-top}--c-button--BorderRadius: var(--pf-t--global--border--radius--large);


This uses the pill radius in design, but I think we can just remove this in favor of the pill radius on the button. I imagine the distinction between this button and the button component is just the font-size, padding, and box-shadow.

andrew-ronaldson · 2023-11-29T20:00:49Z

Can we add text-decoration: none to remove the underline

mcoker · 2023-11-29T20:02:16Z

@andrew-ronaldson I'm going to add that to the button penta updates since it needs to be removed on the button component.

mcoker

🤩

andrew-ronaldson

LGTM, thanks

patternfly-build · 2023-11-30T16:49:56Z

🎉 This PR is included in version 6.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

* feat(breaker): bump this version to 6.0 (patternfly#5800) * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font * feat(text, title, list): apply tokens (patternfly#6031) * feat(page): remove padding on nav sidebar (patternfly#6053) * fix(tokens): adjust font-weight base for headings (patternfly#6070) * feat(login): apply tokens (patternfly#6028) * feat(modal): add tokens to modal and about modal (patternfly#6042) * fix(font): use variable font, add opt-in for legacy font (patternfly#6073) * feat(ExpandableSection): added tokens (patternfly#6063) * feat(Tooltip): applied tokens (patternfly#6064) * feat(Popover): applied tokens (patternfly#6065) * feat(BackToTop): refactor with tokens (patternfly#6085) * feat(SkipToContent): refactor with tokens (patternfly#6090) * feat(Accordion): applied tokens (patternfly#6058) * feat(banner): refactor with tokens (patternfly#6081) * feat(InlineEdit): applied tokens Took a stab at applying the tokens here. There are some items that will be fixed with icon buttons. * chore(tokens): updates tokens from figma (patternfly#6103) * chore(tokens): updating usage of new font tokens (patternfly#6111) * feat(breadcrumb): apply tokens (patternfly#6060) * feat(HelperText): apply tokens (patternfly#6118) * feat(HelperText): first tokens * feat(HelperText): tokens changes * feat(HelperText): fixes * feat(Pagination): applied tokens (patternfly#6089) * feat(Pagination): applied tokens * Removed themes directory * Removed button and menutoggle styles, added wrapper * Removed padding vars for pagination container * Updated tokens and vars for padding * fix(Pagination): updated property order * Updated var names to remove md text * feat(avatar): apply tokens (patternfly#6122) * chore(ExpandableSection): updated Penta docs and focus/hover styling (patternfly#6124) * feat(EmptyState): apply tokens (patternfly#6056) * fix(form): keep form groups/controls from growing too wide (patternfly#6109) * chore(deps): update dependency @patternfly/react-core to v5.1.2 (patternfly#6113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.2 (patternfly#6112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.2 (patternfly#6114) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(card/menu-toggle/check): alignment bugs (patternfly#6110) * feat(SimpleList): pull in new v6 branch (patternfly#6128) * chore: turn on dryrun until release fixed [ci skip] --------- Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

patternfly-build · 2024-01-14T14:39:50Z

🎉 This PR is included in version 6.0.0-alpha.61 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat(BackToTop): refactor with tokens

495e9d3

wise-king-sullyman marked this pull request as draft November 29, 2023 14:16

wise-king-sullyman marked this pull request as ready for review November 29, 2023 18:54

wise-king-sullyman requested review from a team, andrew-ronaldson, lboehling, mattnolting and srambach and removed request for a team November 29, 2023 18:55

mcoker requested changes Nov 29, 2023

View reviewed changes

feat(BackToTop): use proper box shadow token; remove radius

286e2bc

wise-king-sullyman linked an issue Nov 30, 2023 that may be closed by this pull request

Back to Top tokens #6084

Closed

wise-king-sullyman requested a review from mcoker November 30, 2023 14:48

mcoker approved these changes Nov 30, 2023

View reviewed changes

andrew-ronaldson approved these changes Nov 30, 2023

View reviewed changes

mcoker merged commit 714e57a into patternfly:v6 Nov 30, 2023

patternfly-build added the released on @alpha label Nov 30, 2023

wise-king-sullyman deleted the tokenize-back-to-top branch November 30, 2023 18:45

wise-king-sullyman mentioned this pull request Nov 30, 2023

Back to Top tokens #6084

Closed

mcoker pushed a commit to mcoker/patternfly that referenced this pull request Dec 1, 2023

feat(BackToTop): refactor with tokens (patternfly#6085)

bb028ef

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(BackToTop): refactor with tokens (patternfly#6085)

ce1c100

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(BackToTop): refactor with tokens (patternfly#6085)

ad3eeea

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(BackToTop): refactor with tokens (patternfly#6085)

cd81087

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023

feat(BackToTop): refactor with tokens (patternfly#6085)

1875b7b

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 27, 2023

feat(BackToTop): refactor with tokens (patternfly#6085)

9113b5c

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 2, 2024

feat(BackToTop): refactor with tokens (patternfly#6085)

cb7dcb5

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 3, 2024

feat(BackToTop): refactor with tokens (patternfly#6085)

74f6fb9

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 4, 2024

feat(BackToTop): refactor with tokens (patternfly#6085)

5e3c2ef

patternfly-build mentioned this pull request Apr 16, 2025

The automated release is failing 🚨 #7464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(BackToTop): refactor with tokens#6085

feat(BackToTop): refactor with tokens#6085
mcoker merged 2 commits intopatternfly:v6from
wise-king-sullyman:tokenize-back-to-top

wise-king-sullyman commented Nov 28, 2023 •

edited

Loading

Uh oh!

patternfly-build commented Nov 28, 2023 •

edited

Loading

Uh oh!

mcoker left a comment

Uh oh!

mcoker Nov 29, 2023

Uh oh!

mcoker Nov 29, 2023

Uh oh!

andrew-ronaldson commented Nov 29, 2023

Uh oh!

mcoker commented Nov 29, 2023

Uh oh!

mcoker left a comment

Uh oh!

andrew-ronaldson left a comment

Uh oh!

patternfly-build commented Nov 30, 2023

Uh oh!

patternfly-build commented Jan 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wise-king-sullyman commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patternfly-build commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

mcoker Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

mcoker Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

andrew-ronaldson commented Nov 29, 2023

Uh oh!

mcoker commented Nov 29, 2023

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

andrew-ronaldson left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Nov 30, 2023

Uh oh!

patternfly-build commented Jan 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wise-king-sullyman commented Nov 28, 2023 •

edited

Loading

patternfly-build commented Nov 28, 2023 •

edited

Loading