feat(Tooltip): applied tokens #6064

thatblindgeye · 2023-11-15T19:43:17Z

Work towards #5732

Per convo on Figma design file the color/background color are meant to invert in dark mode (white background with black text)

patternfly-build · 2023-11-15T19:46:42Z

Preview: https://patternfly-pr-6064.surge.sh

A11y report: https://patternfly-pr-6064-a11y.surge.sh

srambach · 2023-11-21T14:46:50Z

src/patternfly/components/Tooltip/tooltip.scss

+  --#{$tooltip}__arrow--BackgroundColor: var(--pf-t--global--background--color--inverse--default);
+  --#{$tooltip}__arrow--BoxShadow: var(--pf-t--global--box-shadow--md);
  --#{$tooltip}__arrow--m-top--TranslateX: -50%;
  --#{$tooltip}__arrow--m-top--TranslateY: 50%;


The arrows feel too close to the rounded corners to me. Can the y translations be adjusted to move them in a little without causing other problems?

Otherwise, it looks great!

Checked with @lboehling and it looks ok, though we can keep an eye on it and update later if needed.

mcoker

LGTM!

patternfly-build · 2023-11-27T23:24:16Z

🎉 This PR is included in version 6.0.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

* feat(breaker): bump this version to 6.0 (#5800) * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font * feat(text, title, list): apply tokens (#6031) * feat(page): remove padding on nav sidebar (#6053) * fix(tokens): adjust font-weight base for headings (#6070) * feat(login): apply tokens (#6028) * feat(modal): add tokens to modal and about modal (#6042) * fix(font): use variable font, add opt-in for legacy font (#6073) * feat(ExpandableSection): added tokens (#6063) * feat(Tooltip): applied tokens (#6064) * feat(Popover): applied tokens (#6065) * feat(BackToTop): refactor with tokens (#6085) * feat(SkipToContent): refactor with tokens (#6090) * feat(Accordion): applied tokens (#6058) * feat(banner): refactor with tokens (#6081) * feat(InlineEdit): applied tokens Took a stab at applying the tokens here. There are some items that will be fixed with icon buttons. * chore(tokens): updates tokens from figma (#6103) * chore(tokens): updating usage of new font tokens (#6111) * feat(breadcrumb): apply tokens (#6060) * feat(HelperText): apply tokens (#6118) * feat(HelperText): first tokens * feat(HelperText): tokens changes * feat(HelperText): fixes * feat(Pagination): applied tokens (#6089) * feat(Pagination): applied tokens * Removed themes directory * Removed button and menutoggle styles, added wrapper * Removed padding vars for pagination container * Updated tokens and vars for padding * fix(Pagination): updated property order * Updated var names to remove md text * feat(avatar): apply tokens (#6122) * chore(ExpandableSection): updated Penta docs and focus/hover styling (#6124) * feat(EmptyState): apply tokens (#6056) * fix(form): keep form groups/controls from growing too wide (#6109) * chore(deps): update dependency @patternfly/react-core to v5.1.2 (#6113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.2 (#6112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.2 (#6114) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(card/menu-toggle/check): alignment bugs (#6110) * feat(SimpleList): pull in new v6 branch (#6128) * chore: turn on dryrun until release fixed [ci skip] --------- Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(breaker): bump this version to 6.0 (patternfly#5800) * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font * feat(text, title, list): apply tokens (patternfly#6031) * feat(page): remove padding on nav sidebar (patternfly#6053) * fix(tokens): adjust font-weight base for headings (patternfly#6070) * feat(login): apply tokens (patternfly#6028) * feat(modal): add tokens to modal and about modal (patternfly#6042) * fix(font): use variable font, add opt-in for legacy font (patternfly#6073) * feat(ExpandableSection): added tokens (patternfly#6063) * feat(Tooltip): applied tokens (patternfly#6064) * feat(Popover): applied tokens (patternfly#6065) * feat(BackToTop): refactor with tokens (patternfly#6085) * feat(SkipToContent): refactor with tokens (patternfly#6090) * feat(Accordion): applied tokens (patternfly#6058) * feat(banner): refactor with tokens (patternfly#6081) * feat(InlineEdit): applied tokens Took a stab at applying the tokens here. There are some items that will be fixed with icon buttons. * chore(tokens): updates tokens from figma (patternfly#6103) * chore(tokens): updating usage of new font tokens (patternfly#6111) * feat(breadcrumb): apply tokens (patternfly#6060) * feat(HelperText): apply tokens (patternfly#6118) * feat(HelperText): first tokens * feat(HelperText): tokens changes * feat(HelperText): fixes * feat(Pagination): applied tokens (patternfly#6089) * feat(Pagination): applied tokens * Removed themes directory * Removed button and menutoggle styles, added wrapper * Removed padding vars for pagination container * Updated tokens and vars for padding * fix(Pagination): updated property order * Updated var names to remove md text * feat(avatar): apply tokens (patternfly#6122) * chore(ExpandableSection): updated Penta docs and focus/hover styling (patternfly#6124) * feat(EmptyState): apply tokens (patternfly#6056) * fix(form): keep form groups/controls from growing too wide (patternfly#6109) * chore(deps): update dependency @patternfly/react-core to v5.1.2 (patternfly#6113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.2 (patternfly#6112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.2 (patternfly#6114) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(card/menu-toggle/check): alignment bugs (patternfly#6110) * feat(SimpleList): pull in new v6 branch (patternfly#6128) * chore: turn on dryrun until release fixed [ci skip] --------- Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

patternfly-build · 2024-01-14T14:40:11Z

🎉 This PR is included in version 6.0.0-alpha.61 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat(Tooltip): applied tokens

31d1bc7

Updated color and backgroundcolor tokens

579859a

thatblindgeye requested review from a team, lboehling and mcoker and removed request for a team November 16, 2023 13:10

thatblindgeye linked an issue Nov 16, 2023 that may be closed by this pull request

Consume tokens: Tooltip and Popover #5732

Closed

srambach reviewed Nov 21, 2023

View reviewed changes

mcoker approved these changes Nov 27, 2023

View reviewed changes

mcoker merged commit 0470400 into patternfly:v6 Nov 27, 2023

patternfly-build added the released on @alpha label Nov 27, 2023

thatblindgeye mentioned this pull request Nov 28, 2023

Add "corner" css vars to Tooltip in Penta #6080

Closed

mcoker pushed a commit to mcoker/patternfly that referenced this pull request Dec 1, 2023

feat(Tooltip): applied tokens (patternfly#6064)

16e804c

wise-king-sullyman mentioned this pull request Dec 4, 2023

Consume tokens: Tooltip and Popover #5732

Closed

tlabaj mentioned this pull request Dec 6, 2023

Consume core updates: Tooltip patternfly/patternfly-react#9861

Closed

nicolethoen pushed a commit that referenced this pull request Dec 12, 2023

feat(Tooltip): applied tokens (#6064)

a544411

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

feat(Tooltip): applied tokens (patternfly#6064)

d7553a4

nicolethoen pushed a commit that referenced this pull request Dec 12, 2023

feat(Tooltip): applied tokens (#6064)

9427d50

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(Tooltip): applied tokens (patternfly#6064)

6815293

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(Tooltip): applied tokens (patternfly#6064)

5c78939

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(Tooltip): applied tokens (patternfly#6064)

d3c3e24

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(Tooltip): applied tokens (patternfly#6064)

f0c4ea7

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023

feat(Tooltip): applied tokens (patternfly#6064)

801e600

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 27, 2023

feat(Tooltip): applied tokens (patternfly#6064)

97c061f

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 2, 2024

feat(Tooltip): applied tokens (patternfly#6064)

2efa389

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 3, 2024

feat(Tooltip): applied tokens (patternfly#6064)

10421be

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 4, 2024

feat(Tooltip): applied tokens (patternfly#6064)

9919242

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(Tooltip): applied tokens (patternfly#6064)

ff73c66

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(Tooltip): applied tokens (patternfly#6064)

12ab082

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(Tooltip): applied tokens (patternfly#6064)

833238a

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(Tooltip): applied tokens (patternfly#6064)

3a6ccfc

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(Tooltip): applied tokens (patternfly#6064)

45b4c21

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(Tooltip): applied tokens (patternfly#6064)

a46d79b

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(Tooltip): applied tokens (patternfly#6064)

bdcf095

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(Tooltip): applied tokens (patternfly#6064)

eb249a5

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(Tooltip): applied tokens (patternfly#6064)

2d0bba0

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(Tooltip): applied tokens (patternfly#6064)

8446424

patternfly-build mentioned this pull request Apr 16, 2025

The automated release is failing 🚨 #7464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Tooltip): applied tokens #6064

feat(Tooltip): applied tokens #6064

Uh oh!

thatblindgeye commented Nov 15, 2023 •

edited

Loading

Uh oh!

patternfly-build commented Nov 15, 2023 •

edited

Loading

Uh oh!

srambach Nov 21, 2023

Uh oh!

mcoker Nov 27, 2023

Uh oh!

mcoker left a comment

Uh oh!

patternfly-build commented Nov 27, 2023

Uh oh!

patternfly-build commented Jan 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(Tooltip): applied tokens #6064

feat(Tooltip): applied tokens #6064

Uh oh!

Conversation

thatblindgeye commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patternfly-build commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srambach Nov 21, 2023

Choose a reason for hiding this comment

Uh oh!

mcoker Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Nov 27, 2023

Uh oh!

patternfly-build commented Jan 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thatblindgeye commented Nov 15, 2023 •

edited

Loading

patternfly-build commented Nov 15, 2023 •

edited

Loading