feat(global): remove invalid selector crashing inspector#6051
Closed
srambach wants to merge 1 commit intopatternfly:v6from
Closed
feat(global): remove invalid selector crashing inspector#6051srambach wants to merge 1 commit intopatternfly:v6from
srambach wants to merge 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6051.surge.sh A11y report: https://patternfly-pr-6051-a11y.surge.sh |
evwilkin
approved these changes
Nov 10, 2023
Member
evwilkin
left a comment
evwilkin
left a comment
There was a problem hiding this comment.
LGTM to fix the bug - though would still defer to @mattnolting or @mcoker on any consequences of the specificity increase you called out 👍
Contributor
|
LGTM but this change is also in #6031. That one is ready to merge, too. Do you prefer to keep the change there or in this PR? |
mcoker
approved these changes
Nov 10, 2023
Member
Author
|
@mcoker Either way - just wanted to get this fix into v6 so it's not slowing people down. |
Contributor
|
Addresses in #6031 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:where()with a pseudo element is not valid, and this was causing the inspector in Chrome 119 and Edge to crash. This changes the selector to remove:where. The only side effect is increasing the specificity of that particular rule.