feat(text, title, list): apply tokens #6031

srambach · 2023-11-02T21:23:51Z

PR right before vacation so... 🤪

Also adds modifiers for heading styles to the title component.

patternfly-build · 2023-11-02T21:27:15Z

Preview: https://patternfly-pr-6031.surge.sh

A11y report: https://patternfly-pr-6031-a11y.surge.sh

lboehling · 2023-11-08T17:21:49Z

thanks sarah! this is looking good. I do notice that the top level heading "hello world" in the text component doesn't seem to be pulling in the right size.

mcoker

LGTM, just one typo in a token name.

mcoker · 2023-11-09T22:16:10Z

src/patternfly/components/Title/title.scss

+
+  // h2
+  --#{$title}--m-h2--LineHeight: var(--pf-t--global--font--line-height--heading);
+  --#{$title}--m-h2--FontSize: var(--pf-t--global--font--size--heading-md);


Suggested change

--#{$title}--m-h2--FontSize: var(--pf-t--global--font--size--heading-md);

--#{$title}--m-h2--FontSize: var(--pf-t--global--font--size--heading--md);

mcoker

👍👍

patternfly-build · 2023-11-10T20:23:54Z

🎉 This PR is included in version 6.0.0-alpha.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

* feat(breaker): bump this version to 6.0 (#5800) * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font * feat(text, title, list): apply tokens (#6031) * feat(page): remove padding on nav sidebar (#6053) * fix(tokens): adjust font-weight base for headings (#6070) * feat(login): apply tokens (#6028) * feat(modal): add tokens to modal and about modal (#6042) * fix(font): use variable font, add opt-in for legacy font (#6073) * feat(ExpandableSection): added tokens (#6063) * feat(Tooltip): applied tokens (#6064) * feat(Popover): applied tokens (#6065) * feat(BackToTop): refactor with tokens (#6085) * feat(SkipToContent): refactor with tokens (#6090) * feat(Accordion): applied tokens (#6058) * feat(banner): refactor with tokens (#6081) * feat(InlineEdit): applied tokens Took a stab at applying the tokens here. There are some items that will be fixed with icon buttons. * chore(tokens): updates tokens from figma (#6103) * chore(tokens): updating usage of new font tokens (#6111) * feat(breadcrumb): apply tokens (#6060) * feat(HelperText): apply tokens (#6118) * feat(HelperText): first tokens * feat(HelperText): tokens changes * feat(HelperText): fixes * feat(Pagination): applied tokens (#6089) * feat(Pagination): applied tokens * Removed themes directory * Removed button and menutoggle styles, added wrapper * Removed padding vars for pagination container * Updated tokens and vars for padding * fix(Pagination): updated property order * Updated var names to remove md text * feat(avatar): apply tokens (#6122) * chore(ExpandableSection): updated Penta docs and focus/hover styling (#6124) * feat(EmptyState): apply tokens (#6056) * fix(form): keep form groups/controls from growing too wide (#6109) * chore(deps): update dependency @patternfly/react-core to v5.1.2 (#6113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.2 (#6112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.2 (#6114) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(card/menu-toggle/check): alignment bugs (#6110) * feat(SimpleList): pull in new v6 branch (#6128) * chore: turn on dryrun until release fixed [ci skip] --------- Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(breaker): bump this version to 6.0 (patternfly#5800) * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font * feat(text, title, list): apply tokens (patternfly#6031) * feat(page): remove padding on nav sidebar (patternfly#6053) * fix(tokens): adjust font-weight base for headings (patternfly#6070) * feat(login): apply tokens (patternfly#6028) * feat(modal): add tokens to modal and about modal (patternfly#6042) * fix(font): use variable font, add opt-in for legacy font (patternfly#6073) * feat(ExpandableSection): added tokens (patternfly#6063) * feat(Tooltip): applied tokens (patternfly#6064) * feat(Popover): applied tokens (patternfly#6065) * feat(BackToTop): refactor with tokens (patternfly#6085) * feat(SkipToContent): refactor with tokens (patternfly#6090) * feat(Accordion): applied tokens (patternfly#6058) * feat(banner): refactor with tokens (patternfly#6081) * feat(InlineEdit): applied tokens Took a stab at applying the tokens here. There are some items that will be fixed with icon buttons. * chore(tokens): updates tokens from figma (patternfly#6103) * chore(tokens): updating usage of new font tokens (patternfly#6111) * feat(breadcrumb): apply tokens (patternfly#6060) * feat(HelperText): apply tokens (patternfly#6118) * feat(HelperText): first tokens * feat(HelperText): tokens changes * feat(HelperText): fixes * feat(Pagination): applied tokens (patternfly#6089) * feat(Pagination): applied tokens * Removed themes directory * Removed button and menutoggle styles, added wrapper * Removed padding vars for pagination container * Updated tokens and vars for padding * fix(Pagination): updated property order * Updated var names to remove md text * feat(avatar): apply tokens (patternfly#6122) * chore(ExpandableSection): updated Penta docs and focus/hover styling (patternfly#6124) * feat(EmptyState): apply tokens (patternfly#6056) * fix(form): keep form groups/controls from growing too wide (patternfly#6109) * chore(deps): update dependency @patternfly/react-core to v5.1.2 (patternfly#6113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.2 (patternfly#6112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.2 (patternfly#6114) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(card/menu-toggle/check): alignment bugs (patternfly#6110) * feat(SimpleList): pull in new v6 branch (patternfly#6128) * chore: turn on dryrun until release fixed [ci skip] --------- Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

patternfly-build · 2024-01-14T14:40:29Z

🎉 This PR is included in version 6.0.0-alpha.61 🎉

The release is available on:

Your semantic-release bot 📦🚀

srambach added 2 commits November 2, 2023 17:14

feat(text): apply tokens for content, list, title

cb4aaef

feat(text): add example and documentation

fbab680

srambach requested review from andrew-ronaldson, lboehling, mattnolting and mcoker November 2, 2023 21:24

srambach linked an issue Nov 7, 2023 that may be closed by this pull request

Consume tokens: Title, text, and List #5730

Closed

srambach added 2 commits November 8, 2023 12:41

feat(text): fix typo

112d9d2

feat(text): adjust heading sizes

fc74358

mcoker requested changes Nov 9, 2023

View reviewed changes

feat(text): fix typo

1b62fef

mcoker mentioned this pull request Nov 10, 2023

feat(global): remove invalid selector crashing inspector #6051

Closed

mcoker approved these changes Nov 10, 2023

View reviewed changes

mcoker merged commit f8bf2c0 into patternfly:v6 Nov 10, 2023

patternfly-build added the released on @alpha label Nov 10, 2023

wise-king-sullyman mentioned this pull request Nov 15, 2023

Consume tokens: Title, text, and List #5730

Closed

mcoker pushed a commit to mcoker/patternfly that referenced this pull request Dec 1, 2023

feat(text, title, list): apply tokens (patternfly#6031)

1bca1a6

nicolethoen pushed a commit that referenced this pull request Dec 12, 2023

feat(text, title, list): apply tokens (#6031)

9c378d2

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

feat(text, title, list): apply tokens (patternfly#6031)

09c295d

nicolethoen pushed a commit that referenced this pull request Dec 12, 2023

feat(text, title, list): apply tokens (#6031)

857bd80

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

feat(text, title, list): apply tokens (patternfly#6031)

732dd88

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(text, title, list): apply tokens (patternfly#6031)

8566cd4

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(text, title, list): apply tokens (patternfly#6031)

bb8babd

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 13, 2023

feat(text, title, list): apply tokens (patternfly#6031)

584122c

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023

feat(text, title, list): apply tokens (patternfly#6031)

9c583ac

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 27, 2023

feat(text, title, list): apply tokens (patternfly#6031)

30926b3

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 2, 2024

feat(text, title, list): apply tokens (patternfly#6031)

03c7ccf

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 3, 2024

feat(text, title, list): apply tokens (patternfly#6031)

3cedbab

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 4, 2024

feat(text, title, list): apply tokens (patternfly#6031)

d8646d0

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 9, 2024

feat(text, title, list): apply tokens (patternfly#6031)

2400c3f

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(text, title, list): apply tokens (patternfly#6031)

34f2f94

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(text, title, list): apply tokens (patternfly#6031)

4de219f

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(text, title, list): apply tokens (patternfly#6031)

76e5a5a

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(text, title, list): apply tokens (patternfly#6031)

392d513

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(text, title, list): apply tokens (patternfly#6031)

589bc23

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 15, 2024

feat(text, title, list): apply tokens (patternfly#6031)

8351ea5

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(text, title, list): apply tokens (patternfly#6031)

02c2243

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(text, title, list): apply tokens (patternfly#6031)

4ba5ff9

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(text, title, list): apply tokens (patternfly#6031)

f089dca

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 16, 2024

feat(text, title, list): apply tokens (patternfly#6031)

79fe0d0

patternfly-build mentioned this pull request Apr 16, 2025

The automated release is failing 🚨 #7464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(text, title, list): apply tokens #6031

feat(text, title, list): apply tokens #6031

Uh oh!

srambach commented Nov 2, 2023

Uh oh!

patternfly-build commented Nov 2, 2023 •

edited

Loading

Uh oh!

lboehling commented Nov 8, 2023

Uh oh!

mcoker left a comment •

edited

Loading

Uh oh!

mcoker Nov 9, 2023

Uh oh!

mcoker left a comment

Uh oh!

patternfly-build commented Nov 10, 2023

Uh oh!

patternfly-build commented Jan 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	--#{$title}--m-h2--FontSize: var(--pf-t--global--font--size--heading-md);
	--#{$title}--m-h2--FontSize: var(--pf-t--global--font--size--heading--md);

feat(text, title, list): apply tokens #6031

feat(text, title, list): apply tokens #6031

Uh oh!

Conversation

srambach commented Nov 2, 2023

Uh oh!

patternfly-build commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lboehling commented Nov 8, 2023

Uh oh!

mcoker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcoker Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Nov 10, 2023

Uh oh!

patternfly-build commented Jan 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

patternfly-build commented Nov 2, 2023 •

edited

Loading

mcoker left a comment •

edited

Loading