fix: added base, wizard, pagination RTL styles by mcoker · Pull Request #5860 · patternfly/patternfly

mcoker · 2023-08-24T21:35:35Z

fixes #5839
fixes #5840

Global

Adds a pf-v5-rtl($transform) mixin that manages 2 things so far:
- Handles selector(s) we'll use to wrap RTL styles.
  - Currently works on .ws-dir-rtl, .#{$pf-prefix}m-dir-rtl, [dir="rtl"].
- Can return helpful, common blocks of CSS with a preferred way of doing some RTL transform by passing a $transform.
  - Added a "flip-inline" transform that applies scale: -1 1
Adds .pf-v5-m-rtl-flip-inline as a helper class to flip something horizontally (inline), and gets its code from ^ pf-v5-rtl($transform: "flip-inline")
Adds .pf-v5-m-dir-rtl to apply direction: rtl; to something
Adds .pf-v5-m-dir-ltr to apply direction: ltr; to something if you don't want it to flip in RTL. This is what keeps the dark theme and RTL switches in the bottom right of the full page examples from switching to RTL when the whole document changes to RTL.

Wizard

Added .pf-v5-m-rtl-flip-inline to the wizard icon bem element to flip the icon in the "finished" example. I'll take this out prior to merging, so it isn't confused as something that's required for use in the component. It should probably go on the icon itself anyways, but it was easier to add it to the wizard icon bem element for this example.
Added pf-v5-rtl("flip-inline") to the mobile nav breadcrumb arrows

Pagination

Added pf-v5-rtl("flip-inline") to the next/prev arrows

Follow-ups

I'd like to update the workspace RTL button to use either dir="rtl" (probably preferred, as I think this is our main use case) or .pf-v5-m-dir-rtl on full page examples. Also .pf-v5-m-dir-ltr on the dark theme/RTL switcher box. Then we can remove the current .ws-dir-[rtl/ltr] classes from the workspace code.
Doesn't have to happen, but I'd also like to add a toggle in the masthead on the main workspace view (like the dark theme switcher) that can toggle .pf-v5-m-dir-rtl on the example blocks, which would let us quickly scan RTL examples in the example list page. That should be an easy add. It could eventually toggle the whole page, too, not the example blocks, if we wanted to test the workspace this way.
- We could probably just add a plain action in the masthead that toggles between the FA align-left and align-right icons?

patternfly-build · 2023-08-24T21:40:33Z

Preview: https://patternfly-pr-5860.surge.sh

A11y report: https://patternfly-pr-5860-a11y.surge.sh

thatblindgeye

This looks nice 💪🏼

For the Wizard expandable icon, I'd expect that when collapsed it would be facing to the left when rtl is enabled. By default we have the nav link text followed by the toggle icon facing right (away from the link text), but with RTL enabled we have the toggle icon facing right (towards the link text) followed by the link text. This would follow how the tree view dual list selector is styled, where the icon is facing towards the item text in both LTR and RTL.

Can we just add in the @include pf-v5-rtl("flip-inline"); in the nav-link-toggle-icon block around line ~536 to resolve that?

thatblindgeye · 2023-08-25T13:18:26Z

src/patternfly/sass-utilities/mixins.scss

 }
+
+@mixin pf-v5-rtl($transform: null) {
+  @at-root :where(.ws-dir-rtl, .#{$pf-prefix}m-dir-rtl, [dir="rtl"]) & {


Checked and looks to work well when applying dir attribute, ws-dir-rtl class, and the modifier class to either the html tag or the base component tag 👍🏼

mcoker · 2023-08-25T16:01:12Z

@thatblindgeye nice find, updated!

wise-king-sullyman · 2023-08-25T17:13:39Z

It looks like the ofs in pagination are off?

wise-king-sullyman · 2023-08-25T17:18:49Z

Also no idea if this is actually an issue, but it's interesting to me that the text itself doesn't change, but the period moves around in the text here. Is that expected?

thatblindgeye

🚀 Only have a nit below, but ti isn't blocking for this PR.

thatblindgeye · 2023-08-25T17:19:36Z

src/patternfly/sass-utilities/mixins.scss

+// Applies custom styles to support RTL
+@mixin pf-v5-rtl($transform: null) {
+  // resets property used to inverse transform values calc()s in RTL
+  @if $transform == "transform-flip-revert" {


Only nit is the naming of this particular value. Just wondering if "transform-flip(-revert)" conveys exactly what it's for, or if it's too close to "flip-inline"... "transform-modifier(-revert)" or "transform-multiplier(-revert)" maybe?

thatblindgeye · 2023-08-25T17:26:28Z

@wise-king-sullyman I feel like those are expected? If I render just the text Lorem ipsum. or 1-10 of 36 in a plain div, applying rtl to it it's the same result.

mcoker · 2023-08-25T17:27:39Z

Also no idea if this is actually an issue, but it's interesting to me that the text itself doesn't change, but the period moves around in the text here. Is that expected?

@wise-king-sullyman I noticed that, too, and it appears to just be the way punctuation is handled between LTR/RTL. I don't think there's anything we can do about that, and I think it changes based on your language.

mcoker · 2023-08-25T17:41:47Z

It looks like the ofs in pagination are off?

Since those are just strings in core, I think that would look right in the correct language.

thatblindgeye · 2023-08-25T17:47:26Z

Granted I'm viewing it after having the page translated to English, but when I go to the BBC site for Arabic, things look similar there where the punctuation is at the "start" (to us), and instead of "6 hours ago" an article reads "hours ago 6" (which would align to the Pagination x of y text).

mattnolting

Let's merge.

patternfly-build · 2023-08-25T18:20:49Z

🎉 This PR is included in version 5.1.0-prerelease.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

* chore(select): fixed text in HTML example to show multiple checks can be selected (#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (#5798) * chore(options-menu): updated markup to match react component (#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (#5807) * fix(chip): add margin for badge when used in text element (#5844) * feat(global): added RTL support (#5778) * fix: added tree view icon (#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (#5859) * docs: update location of and references to docs to consolidate and organize information. (#5773) * fix: added base, wizard, pagination RTL styles (#5860) * chore(Accordion,ExpandableSection): added more RTL styling (#5861) * fix(RTL): refactor mixins, add slider rtl styles (#5867) * fix(nav): added optional text wrapper for nav text (#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (#5862) * fix(breadcrumb): added rtl support (#5870) * chore(card): updated horiz demo image (#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (#5873) * fix(clipboard-copy): added rtl styles (#5876) * fix(page): added rtl styles (#5878) * fix(calendar-month): rtl support (#5869) * chore(Card,Tile): apply RTL fixes (#5881) * fix: added tabs and jump links rtl styles (#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (#5882) * fix(tree-view): added rtl styles (#5883) * chore(Table): added additional RTL styling (#5887) * chore(Drawer): transforms and shadows on RTL drawer (#5888) * fix(forms): updated rtl styles (#5889) * fix(skeleton): added rtl styles (#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (#5895) * chore(ModalBox): center modal for workspace in RTL (#5893) * fix(rtl): fixes truncate rtl (#5874) * fix(ModalBox): fix centering on mobile (#5905) * chore: added backstop as dev dependency, update config (#5904) * chore(popover): center examples (#5906) * fix(nav): updated example css (#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (#5912) * chore: update screenshots (#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (#5920) * fix: mirror bg image position in rtl (#5922) * fix(progress): updated indicator direction (#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (#5941) * fix(card): removed border from clickable/selectable selected (#5935) * feat(Button): extended inline styling (#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (#5924) * fix(toolbar): fix expand all icon in RTL (#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (#5971) * chore(Toolbar): increase workspace container height (#5962) * chore(screenshots): update visual regression screenshots (#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (#5681) * fix(input): standardized check and radio alignment (#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (#5995) * chore(menu-toggle): updated demos to use menu-toggle (#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (#6044) * feat(breaker): bump this version to 6.0 (#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * chore(v6): merge main into v6 (#5981) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ashley Ray <123661468+ashley-o0o@users.noreply.github.com> Co-authored-by: Nicole Thoen <nthoen@redhat.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

* chore(select): fixed text in HTML example to show multiple checks can be selected (patternfly#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (patternfly#5798) * chore(options-menu): updated markup to match react component (patternfly#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (patternfly#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (patternfly#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (patternfly#5807) * fix(chip): add margin for badge when used in text element (patternfly#5844) * feat(global): added RTL support (patternfly#5778) * fix: added tree view icon (patternfly#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (patternfly#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (patternfly#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (patternfly#5859) * docs: update location of and references to docs to consolidate and organize information. (patternfly#5773) * fix: added base, wizard, pagination RTL styles (patternfly#5860) * chore(Accordion,ExpandableSection): added more RTL styling (patternfly#5861) * fix(RTL): refactor mixins, add slider rtl styles (patternfly#5867) * fix(nav): added optional text wrapper for nav text (patternfly#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (patternfly#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (patternfly#5862) * fix(breadcrumb): added rtl support (patternfly#5870) * chore(card): updated horiz demo image (patternfly#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (patternfly#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (patternfly#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (patternfly#5873) * fix(clipboard-copy): added rtl styles (patternfly#5876) * fix(page): added rtl styles (patternfly#5878) * fix(calendar-month): rtl support (patternfly#5869) * chore(Card,Tile): apply RTL fixes (patternfly#5881) * fix: added tabs and jump links rtl styles (patternfly#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (patternfly#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (patternfly#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (patternfly#5882) * fix(tree-view): added rtl styles (patternfly#5883) * chore(Table): added additional RTL styling (patternfly#5887) * chore(Drawer): transforms and shadows on RTL drawer (patternfly#5888) * fix(forms): updated rtl styles (patternfly#5889) * fix(skeleton): added rtl styles (patternfly#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (patternfly#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (patternfly#5895) * chore(ModalBox): center modal for workspace in RTL (patternfly#5893) * fix(rtl): fixes truncate rtl (patternfly#5874) * fix(ModalBox): fix centering on mobile (patternfly#5905) * chore: added backstop as dev dependency, update config (patternfly#5904) * chore(popover): center examples (patternfly#5906) * fix(nav): updated example css (patternfly#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (patternfly#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (patternfly#5912) * chore: update screenshots (patternfly#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (patternfly#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (patternfly#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (patternfly#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (patternfly#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (patternfly#5920) * fix: mirror bg image position in rtl (patternfly#5922) * fix(progress): updated indicator direction (patternfly#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (patternfly#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (patternfly#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (patternfly#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (patternfly#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (patternfly#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (patternfly#5941) * fix(card): removed border from clickable/selectable selected (patternfly#5935) * feat(Button): extended inline styling (patternfly#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (patternfly#5924) * fix(toolbar): fix expand all icon in RTL (patternfly#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (patternfly#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (patternfly#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (patternfly#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (patternfly#5971) * chore(Toolbar): increase workspace container height (patternfly#5962) * chore(screenshots): update visual regression screenshots (patternfly#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (patternfly#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (patternfly#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (patternfly#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (patternfly#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (patternfly#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (patternfly#5681) * fix(input): standardized check and radio alignment (patternfly#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (patternfly#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (patternfly#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (patternfly#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (patternfly#5995) * chore(menu-toggle): updated demos to use menu-toggle (patternfly#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (patternfly#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (patternfly#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (patternfly#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (patternfly#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (patternfly#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (patternfly#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (patternfly#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (patternfly#6044) * feat(breaker): bump this version to 6.0 (patternfly#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * chore(v6): merge main into v6 (patternfly#5981) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ashley Ray <123661468+ashley-o0o@users.noreply.github.com> Co-authored-by: Nicole Thoen <nthoen@redhat.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

mcoker force-pushed the issue-5839 branch 3 times, most recently from 579fa2d to e7e48de Compare August 24, 2023 21:52

fix: added base, wizard, pagination RTL styles

b9e2856

mcoker force-pushed the issue-5839 branch from e7e48de to b9e2856 Compare August 24, 2023 22:23

mcoker changed the title ~~fix(wizard): added RTL styles~~ fix: added base, wizard, pagination RTL styles Aug 24, 2023

mcoker requested review from evwilkin, mattnolting and thatblindgeye August 24, 2023 23:34

fix: dual list selector rtl

02bed30

thatblindgeye requested changes Aug 25, 2023

View reviewed changes

chore: updates

f0f5876

mcoker requested review from thatblindgeye and wise-king-sullyman August 25, 2023 16:01

thatblindgeye approved these changes Aug 25, 2023

View reviewed changes

mattnolting approved these changes Aug 25, 2023

View reviewed changes

mcoker merged commit 2436fd3 into patternfly:main Aug 25, 2023

patternfly-build added the released on @prerelease label Aug 25, 2023

This was referenced Aug 25, 2023

Implement RTL: dual list selector #5838

Closed

Implement RTL: drag and drop #5837

Closed

fix(RTL): refactor mixins, add slider rtl styles #5867

Merged

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

fix: added base, wizard, pagination RTL styles (patternfly#5860)

b3b460d

mcoker deleted the issue-5839 branch January 7, 2025 16:47

Conversation

mcoker commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Global

Wizard

Pagination

Follow-ups

Uh oh!

patternfly-build commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

thatblindgeye Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

mcoker commented Aug 25, 2023

Uh oh!

wise-king-sullyman commented Aug 25, 2023

Uh oh!

wise-king-sullyman commented Aug 25, 2023

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

thatblindgeye Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

thatblindgeye commented Aug 25, 2023

Uh oh!

mcoker commented Aug 25, 2023

Uh oh!

mcoker commented Aug 25, 2023

Uh oh!

thatblindgeye commented Aug 25, 2023

Uh oh!

mattnolting left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Aug 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mcoker commented Aug 24, 2023 •

edited

Loading

patternfly-build commented Aug 24, 2023 •

edited

Loading