fix(select,dropdown): mark select and dropdown as deprecated #5667
+122
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-pr-5667.surge.sh A11y report: https://patternfly-pr-5667-a11y.surge.sh |
mcoker
approved these changes
Jun 13, 2023
| #ws-html-deprecated-c-select-loading-menu-item, | ||
| #ws-html-deprecated-c-select-placeholder-expanded, | ||
| #ws-html-deprecated-c-select-placeholder-item-disabled, | ||
| #ws-html-deprecated-c-select-placeholder-item-enabled { |
Contributor
There was a problem hiding this comment.
@ashley-o0o noticed an example is missing a height today - https://patternfly-pr-5667.surge.sh/components/menus/select#multi-with-typeahead-invalid
A wee bit of scope creep, but could we sneak that fix in here? The ID for that example is ws-html-deprecated-c-select-multi-with-typeahead-invalid
Suggested change
| #ws-html-deprecated-c-select-placeholder-item-enabled { | |
| #ws-html-deprecated-c-select-placeholder-item-enabled, | |
| #ws-html-deprecated-c-select-multi-with-typeahead-invalid { |
mcoker
approved these changes
Jun 13, 2023
Collaborator
|
🎉 This PR is included in version 5.0.0-prerelease.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.