feat(deps): introduce stylelint-use-logical-spec stylelint plugin #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this new linter check when linting new code. This enforces the usage of Logical Properties and Values in CSS. More info @ https://www.npmjs.com/package/stylelint-use-logical-spec Partially Fixes patternfly#5555
KKoukiou
force-pushed
the
stylelint-logical
branch
from
c35eebd to
2c928b8
Compare
Contributor
Author
|
I am not able to see the failure logs - and this builds locally. But anyhow, we can first discuss it if you even agree with the approach. |
Collaborator
|
Preview: https://patternfly-pr-5556.surge.sh A11y report: https://patternfly-pr-5556-a11y.surge.sh |
|
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this new linter check when linting new code.
This enforces the usage of Logical Properties and Values in CSS.
More info @ https://www.npmjs.com/package/stylelint-use-logical-spec
Partially Fixes #5555