Skip to content

fix(tabs): remove pagination, expose tags #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 2 commits into from
Dec 5, 2022
+6 −254
Merged

fix(tabs): remove pagination, expose tags #5259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0488c4
fix(tabs): remove pagination, expose tags
jenny-s51 Nov 28, 2022
0450a7e
fix(tabs): update labels
jenny-s51 Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/patternfly/demos/PrimaryDetail/primary-detail-template-panel-body.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
}}
{{/progress}}
{{/l-flex-item}}
{{#if primary-detail-panel-tab-content--HasLabels}}
{{#if primary-detail-template-panel-tab-content--HasLabels}}
{{#> l-flex l-flex--modifier="pf-m-column"}}
{{#> l-flex-item}}
{{#> title titleType="h3" title--attribute=(concat 'id="' primary-detail-template--id '-title"')}}
Expand All @@ -38,22 +38,17 @@
{{/label-group-list-item}}
{{#> label-group-list-item}}
{{#> label label--modifier="pf-m-outline"}}
Different tag 1
Tag 2
{{/label}}
{{/label-group-list-item}}
{{#> label-group-list-item}}
{{#> label label--modifier="pf-m-outline"}}
Another different tag 1
Tag 3
{{/label}}
{{/label-group-list-item}}
{{#> label-group-list-item}}
{{#> label label--modifier="pf-m-outline"}}
Another different tag 2
{{/label}}
{{/label-group-list-item}}
{{#> label-group-list-item}}
{{#> label label--modifier="pf-m-outline"}}
Different than tag 1 or 2
{{#> label label--modifier="pf-m-overflow"}}
2 more
{{/label}}
{{/label-group-list-item}}
{{/label-group-list}}
Expand Down
5 changes: 1 addition & 4 deletions src/patternfly/demos/Tabs/examples/Tabs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ section: components
toolbar-template--modifier="pf-m-page-insets"
toolbar-template--HasToggleGroup="true"
toolbar-template--HasFilter="true"
toolbar-template--HasNoPagination="true"
toolbar-template--HasSortButton="true"
toolbar-template--HasOverflowMenu="true"
toolbar-template--HasOverflowMenuSecondButton="true"
Expand All @@ -346,10 +347,6 @@ section: components
<!-- Content -->
{{#> drawer-content}}
{{> tabs--table}}
{{#> pagination pagination--modifier="pf-m-bottom"}}
{{> pagination-options-menu pagination-options-menu--id=(concat tabs--page-wrapper--id '-footer-pagination') pagination-options-menu--modifier="pf-m-top"}}
{{> pagination-nav-content}}
{{/pagination}}
{{/drawer-content}}

<!-- Panel -->
Expand Down
240 changes: 0 additions & 240 deletions src/patternfly/demos/Tabs/tabs--table.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,245 +263,5 @@
{{> tabs--table-overflow-menu tabs--table-overflow-menu--id=(concat table--id "-dropdown-kebab-5")}}
{{/table-td}}
{{/table-tr}}

{{#> table-tr}}
{{#> table-td table-td--check="true"}}
<input type="checkbox" name="checkrow6" aria-labelledby="{{table--id}}-node6">
{{/table-td}}
{{#> table-th table-th--data-label="Repository name"}}
<div>
<div id="{{table--id}}-node6">Node 6</div>
<a href="#">siemur/test-space</a>
</div>
{{/table-th}}
{{#> table-td table-td--data-label="Branches"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
34
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code-branch"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Pull requests"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
21
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Workspaces"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
26
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-cube"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Last commit"}}
2 days ago
{{/table-td}}
{{#> table-td table-td--action="true"}}
{{> tabs--table-overflow-menu tabs--table-overflow-menu--id=(concat table--id "-dropdown-kebab-6")}}
{{/table-td}}
{{/table-tr}}

{{#> table-tr}}
{{#> table-td table-td--check="true"}}
<input type="checkbox" name="checkrow7" aria-labelledby="{{table--id}}-node7">
{{/table-td}}
{{#> table-th table-th--data-label="Repository name"}}
<div>
<div id="{{table--id}}-node7">Node 7</div>
<a href="#">siemur/test-space</a>
</div>
{{/table-th}}
{{#> table-td table-td--data-label="Branches"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
34
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code-branch"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Pull requests"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
21
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Workspaces"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
26
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-cube"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Last commit"}}
2 days ago
{{/table-td}}
{{#> table-td table-td--action="true"}}
{{> tabs--table-overflow-menu tabs--table-overflow-menu--id=(concat table--id "-dropdown-kebab-7")}}
{{/table-td}}
{{/table-tr}}

{{#> table-tr}}
{{#> table-td table-td--check="true"}}
<input type="checkbox" name="checkrow8" aria-labelledby="{{table--id}}-node8">
{{/table-td}}
{{#> table-th table-th--data-label="Repository name"}}
<div>
<div id="{{table--id}}-node8">Node 8</div>
<a href="#">siemur/test-space</a>
</div>
{{/table-th}}
{{#> table-td table-td--data-label="Branches"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
34
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code-branch"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Pull requests"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
21
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Workspaces"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
26
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-cube"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Last commit"}}
2 days ago
{{/table-td}}
{{#> table-td table-td--action="true"}}
{{> tabs--table-overflow-menu tabs--table-overflow-menu--id=(concat table--id "-dropdown-kebab-8")}}
{{/table-td}}
{{/table-tr}}

{{#> table-tr}}
{{#> table-td table-td--check="true"}}
<input type="checkbox" name="checkrow9" aria-labelledby="{{table--id}}-node9">
{{/table-td}}
{{#> table-th table-th--data-label="Repository name"}}
<div>
<div id="{{table--id}}-node9">Node 9</div>
<a href="#">siemur/test-space</a>
</div>
{{/table-th}}
{{#> table-td table-td--data-label="Branches"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
34
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code-branch"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Pull requests"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
21
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Workspaces"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
26
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-cube"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Last commit"}}
2 days ago
{{/table-td}}
{{#> table-td table-td--action="true"}}
{{> tabs--table-overflow-menu tabs--table-overflow-menu--id=(concat table--id "-dropdown-kebab-9")}}
{{/table-td}}
{{/table-tr}}

{{#> table-tr}}
{{#> table-td table-td--check="true"}}
<input type="checkbox" name="checkrow10" aria-labelledby="{{table--id}}-node10">
{{/table-td}}
{{#> table-th table-th--data-label="Repository name"}}
<div>
<div id="{{table--id}}-node10">Node 10</div>
<a href="#">siemur/test-space</a>
</div>
{{/table-th}}
{{#> table-td table-td--data-label="Branches"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
34
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code-branch"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Pull requests"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
21
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-code"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Workspaces"}}
{{#> l-flex l-flex--modifier="pf-m-space-items-sm pf-m-nowrap"}}
{{#> l-flex-item}}
26
{{/l-flex-item}}
{{#> l-flex-item}}
<i class="fas fa-cube"></i>
{{/l-flex-item}}
{{/l-flex}}
{{/table-td}}
{{#> table-td table-td--data-label="Last commit"}}
2 days ago
{{/table-td}}
{{#> table-td table-td--action="true"}}
{{> tabs--table-overflow-menu tabs--table-overflow-menu--id=(concat table--id "-dropdown-kebab-10")}}
{{/table-td}}
{{/table-tr}}
{{/table-tbody}}
{{/table}}