fix(LabelGroup): updated tab order to match visual order#5172
Closed
thatblindgeye wants to merge 1 commit intopatternfly:mainfrom
Closed
fix(LabelGroup): updated tab order to match visual order#5172thatblindgeye wants to merge 1 commit intopatternfly:mainfrom
thatblindgeye wants to merge 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-pr-5172.surge.sh A11y report: https://patternfly-pr-5172-a11y.surge.sh |
Contributor
Author
|
@mcoker @jessiehuff Nicole and I had a quick chat regarding this update, and we're both leaning towards keeping things as-is per the reasons stated above (may cause confusion if we update the tab order for vertical only and either train of thought makes sense; Nicole also brought up a good point about how having the close button in the middle may interrupt the flow for screen readers). Would both of you agree with that? |
Contributor
|
@thatblindgeye sounds good to me! |
Contributor
Author
|
Spoke with Jessie, and based on the discussion above for now I'll close this PR and issue (as well as the React followup). |
This was referenced Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for #5122
Had a conversation with @mcoker regarding this and #5157. The tldr is that this can be a bit of a gray area, where both the visual order and the logical/expected order both make sense.
The following link should link to the "Vertical category removable, updated markup" example which shows a potential fix for the linked issue. The example immediately below it, "Vertical category removable", is the behavior seen in our React repo.
Label group
For label group with truncated label + overflow button + close button, the visual order seems to be more left to right, top to bottom, e.g. the label should receive focus, then the close button (visually to the right of the label), then the overflow. However:
Placing the interactive elements in an order that follows sequences and relationships within the content may be relevant.
@jessiehuff @nicolethoen your input would be appreciated