Skip to content

fix(Slider): reorder slider thumb and slider input elements#5157

Closed
ruibrii wants to merge 2 commits intopatternfly:mainfrom
ruibrii:5121-slider-incorrect-tab-order
Closed

fix(Slider): reorder slider thumb and slider input elements#5157
ruibrii wants to merge 2 commits intopatternfly:mainfrom
ruibrii:5121-slider-incorrect-tab-order

Conversation

@ruibrii
Copy link
Contributor

@ruibrii ruibrii commented Oct 10, 2022

Closes #5121

Swapped slider thumb and slider input elements so that the tab order is correct (i.e., tab to input first, then slider).

@patternfly-build
Copy link
Collaborator

patternfly-build commented Oct 10, 2022

@ruibrii ruibrii marked this pull request as ready for review October 10, 2022 17:34
@thatblindgeye
Copy link
Contributor

@RuiBrian Just wanted to let you know #5172 has been opened with some discussion that is related to this PR.

@mcoker
Copy link
Contributor

mcoker commented Oct 18, 2022

@thatblindgeye and I discussed and I think a consideration for this should be that the floating input is currently more like a popover/tooltip attached to the thumb. I can see updating this input to use popper with a floating/plain popover (without the box), and then the input may be before or after the thumb in any direction when the orientation of the input flips. Conceptually, I think the thumb is the primary adjustment on the slider, and the input is a representation of, and a way to change, the thumb's value. So I think there is a strong use case for the thumb remaining first in the tab order.

@ruibrii
Copy link
Contributor Author

ruibrii commented Oct 18, 2022

I see, that makes sense. Should we go ahead and close this PR then?

@thatblindgeye
Copy link
Contributor

@nicolethoen @jessiehuff for visibility, Michael's comments regarding the Slider are above. Would either of you agree with keeping the slider as-is as well (similar to the Label Group PR), or is the Slider just different enough to warrant a markup update?

@nicolethoen
Copy link
Contributor

Leaving it as is sounds fine to me.

@thatblindgeye
Copy link
Contributor

After the discussion Michael and I had I would be in the same boat; it definitely feels like it could go either way/either approach could be valid. And considering this was something I had noticed/created the issue for, it may not be something users themselves are facing an issue over so I'd be more comfortable closing things for now if that's the way we want to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Slider: tab order incorrect when input is above thumb

5 participants