feat(form): added group role to section and field group #4424
Conversation
|
Preview: https://patternfly-pr-4424.surge.sh |
| @@ -1,4 +1,8 @@ | |||
| <section class="pf-c-form__section{{#if form-section--modifier}} {{form-section--modifier}}{{/if}}" | |||
| {{#unless form-section--HasNoTitle}} | |||
There was a problem hiding this comment.
This should always have role="group", no? And either aria-label if form-section--HasNoTitle, otherwise aria-labelledby="[title id]"
| @@ -1,4 +1,8 @@ | |||
| <div class="pf-c-form__field-group{{#if form-field-group--IsExpanded}} pf-m-expanded{{/if}}{{#if form-field-group--modifier}} {{form-field-group--modifier}}{{/if}}" | |||
| {{#unless form-field-group--HasNoTitle}} | |||
There was a problem hiding this comment.
This should always have role="group", no? And either aria-label if form-field-group--HasNoTitle, otherwise aria-labelledby="[title id]"
There was a problem hiding this comment.
I agree that it should probably always have the role. I can see the benefit of your second comment, though Jenn's comment here argues that maybe there shouldn't be an aria-label if there's no title. I could argue either way. I think it probably depends on the implementation. If there is a visual indication in the UI, the user should probably add an aria-label to also indicate that, but in our example, I can see that maybe an aria-label isn't really necessary.
mattnolting
force-pushed
the
feat-forms-issue-4276
branch
from
a45da44 to
ab6022a
Compare
|
🎉 This PR is included in version 4.146.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
closes #4276