Merged
Conversation
added 8 commits
November 29, 2016 15:41
…the graph can use it as ID
Rationale: The user sees some progress and it helps to see if anything was done at all
…ays recompiling all pseudopatterns
Member
|
@tburny thanks for this - and all the comments. Like we discussed - I will start combing through it asap for a 2.8.0-alpha. In the meantime, if you could attempt to fix the eslint errors that'd help a ton. |
Author
Sure. |
added 6 commits
December 1, 2016 21:37
…blic from gitignore
When changing the structure of a PatternGraph, users might still have an old version, so we need to rebuild all patterns and the whole graph.
Member
|
@tburny I have started testing this today |
Member
|
@tburny appears broken if my test:
changing it to |
Member
|
scratch that - merging |
Member
This outputs only changed patterns. 3.2.1. 🚀 >>>>>>>>>>>>>>>>>>>>>🎯 💣
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Addresses #540 _
Summary of changes:
This is a prototype for recompiling any templates that have been modified since they have been previously built. This works by inspecting the source and output files' modification timestamps.
A pattern is marked as
needs rebuildif any of its source files was modified after the modification timestamp of the output file. When the template was built and the output was written to disk, it is marked ascleanto prevent building templates more than once.Working
A pattern is recompiled iif
Not working yet
patternlab:servewill wipe the output folder. We can provide a seperate goal.