Skip to content

Engine hooks for file writing#542

Merged
bmuenzenmeyer merged 3 commits intodevfrom
engine-hooks-for-file-writing
Oct 28, 2016
Merged

Engine hooks for file writing#542
bmuenzenmeyer merged 3 commits intodevfrom
engine-hooks-for-file-writing

Conversation

@geoffp
Copy link
Copy Markdown
Contributor

@geoffp geoffp commented Oct 23, 2016

Addresses #541

Summary of changes:

  • Ask the linter to tolerate es6 syntax; all the es6 syntax herein was chosen to be compatible back to Node 4.4
  • Factor out writePatternFiles()
  • Preserve the current scheme as the default formatter, and provide hooks for engines to be able to implement their own
  • Add a hook for engines to be able to add files to the output if they need to

bmuenzenmeyer
bmuenzenmeyer approved these changes Oct 28, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very smart solution. Thanks Geoff!

@bmuenzenmeyer bmuenzenmeyer merged commit 0607e06 into dev Oct 28, 2016
@bmuenzenmeyer bmuenzenmeyer deleted the engine-hooks-for-file-writing branch October 28, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels

enhancement ✨ fix / refactor 🚧

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geoffp @bmuenzenmeyer