Merged
Conversation
correct static file paths; add and fix unit tests
config into Pattern object initialization
parameter so it can construct correct pattern links based on the configure outputFilePaths in the user config
| //write the compiled template to the public patterns directory | ||
| var patternPage = headHTML + pattern.patternPartialCode + footerHTML; | ||
| fs.outputFileSync(paths.public.patterns + pattern.patternLink.replace('.html', patternlab.config.outputFileSuffixes.rendered + '.html'), patternPage); | ||
| fs.outputFileSync(paths.public.patterns + pattern.getPatternLink(patternlab, 'rendered'), patternPage); |
Member
|
I made one slight change to account for info panel template |
Contributor
Author
|
@bmuenzenmeyer, good catch! Sorry I missed that. Makes me want to run off and start doing functional testing. |
Member
|
I think everything is good now! If you could give 2.4.3 a spin, that would be great |
Contributor
Author
|
Doin' that now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #438, Addresses #437
Summary of changes:
In here, we change the way that Pattern object are initialized. To generate a correct patternLink, which is needed for pattern links in "view all" views to work, the Pattern object now needs access to the config, because the names of output files are now configurable. Therefore, we pass the global patternlab object into the Pattern constructor.
We also update the outputFileSuffixes blobs to the latest defaults throughout, fix a bunch of engine-specific unit tests, and do a little whitespace cleanup for good measure.