Find partial to get partial#413
Merged
bmuenzenmeyer merged 6 commits intopattern-lab:devfrom Aug 11, 2016
e2tha-e:findPartial-to-getPartial
Merged
Find partial to get partial#413bmuenzenmeyer merged 6 commits intopattern-lab:devfrom e2tha-e:findPartial-to-getPartial
bmuenzenmeyer merged 6 commits intopattern-lab:devfrom
e2tha-e:findPartial-to-getPartial
Conversation
Member
|
A thorough PR that aligns with the roadmap - thanks ! |
bmuenzenmeyer
added a commit
that referenced
this pull request
Aug 13, 2016
…Partial... introduced during #413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #407
Summary of changes:
@bmuenzenmeyer
Mostly just simple name changes. This helps when grepping for one function vs the other.
Also includes minor updates to the getPartial function itself. One avoids string-concatenation and the hard-coded "mustache" extension. Another replaces
throwwithconsole.errorbecausethrowthrows misleading messages when the error is nothing more than a match not being found.