Minor Nav Refactor + Fix for Overlapping Dropdown Menus#1160
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two basic changes to the Nav in Pattern Lab's UIKit:
It starts to tackle the overall Nav refactor I started in UIKit Nav Cleanup #1102 by breaking apart the existing Nav UI into smaller, more manageable pieces, but without any visual or functional changes. This should help make any additional Nav refactor work a lot more palatable.
It fixes the annoying bug of having overlapping dropdown menus (on larger screens while the Nav is in Horizontal mode).