Implement GraverBasis class for integer matrices #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GraverBasis class for computing and iterating over the Graver basis of integer matrices. Please notify me if there is some changes needed for formate or informative reasons, I will get to them soon as possible
Contributor
Author
|
I will try to dig in and correct the failing checks, will update again. |
To refactor orthogonal_range_search method to improve input validation and iterator generation.
Added ambient free module ZZ^n for range/coercion utilities and updated examples.
Refactor orthogonal_range_search to use library implementation and restore ambient method.
Added a comment to clarify the creation of row_mat.
Removed the ambient free module ZZ^n usage and adjusted related methods to directly yield Graver basis vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GraverBasis class for computing and iterating over the Graver basis of integer matrices.
Please notify me if there is some changes needed for formate or informative reasons, I will get to them soon as possible