Skip to content

dist.yml (wheels): Install gap_packages, gap_pkg_jupyterkernel #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkoeppe merged 4 commits into from
Aug 9, 2025
Merged

dist.yml (wheels): Install gap_packages, gap_pkg_jupyterkernel #1342

mkoeppe merged 4 commits into from
Aug 9, 2025

Conversation

@mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jul 27, 2025

No description provided.

@mkoeppe mkoeppe force-pushed the passagemath-gap--include-gap_packages branch from cadf876 to 0f66092 Compare July 27, 2025 02:26
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 27, 2025

It's too big:

1 wheels produced in 3 minutes:
  passagemath_gap-10.6.1rc12-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl   331,759 kB

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 28, 2025 •
edited
Loading

The semigroups package is extremely large, and not because of data. Perhaps objects linked statically against GAP?

$ du -sh local/lib/gap/pkg/semigroups/{bin,gen}
73M	 local/lib/gap/pkg/semigroups/bin
374M	local/lib/gap/pkg/semigroups/gen

@mkoeppe mkoeppe force-pushed the passagemath-gap--include-gap_packages branch 2 times, most recently from c483319 to dd9768b Compare July 28, 2025 06:33
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 28, 2025 •
edited
Loading

on manylinux x86_64:

  [gap_packages-4.14.0.p0]   [spkg-install] In file included from /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/hpcombi.hpp:19,
  [gap_packages-4.14.0.p0]   [spkg-install]                  from /host/sage-manylinux_2_28_x86_64/include/libsemigroups/hpcombi.hpp:35,
  [gap_packages-4.14.0.p0]   [spkg-install]                  from /host/sage-manylinux_2_28_x86_64/include/libsemigroups/transf.hpp:49,
  [gap_packages-4.14.0.p0]   [spkg-install]                  from src/to_cpp.hpp:59,
  [gap_packages-4.14.0.p0]   [spkg-install]                  from src/froidure-pin-base.cpp:22:
  [gap_packages-4.14.0.p0]   [spkg-install] /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/epu.hpp:42:17: note: '#pragma message: Using a constexpr broken compiler ! Performance may not be optimal'
  [gap_packages-4.14.0.p0]   [spkg-install]    42 |                 "Performance may not be optimal"
  [gap_packages-4.14.0.p0]   [spkg-install]       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  [gap_packages-4.14.0.p0]   [spkg-install] /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/epu.hpp:64:29: error: static assertion failed: xpu8 type is not properly aligned by the compiler !
  [gap_packages-4.14.0.p0]   [spkg-install]    64 | static_assert(alignof(xpu8) == 32,
  [gap_packages-4.14.0.p0]   [spkg-install]       |               ~~~~~~~~~~~~~~^~~~~
  [gap_packages-4.14.0.p0]   [spkg-install] /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/epu.hpp:64:29: note: the comparison reduces to '(16 == 32)'
  [gap_packages-4.14.0.p0]   [spkg-install] /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/epu.hpp: In function 'bool HPCombi::is_all_zero(epu8)':
  [gap_packages-4.14.0.p0]   [spkg-install] /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/epu.hpp:205:57: note: use '-flax-vector-conversions' to permit conversions between vectors with differing element types or numbers of subparts
  [gap_packages-4.14.0.p0]   [spkg-install]   205 | inline bool is_all_zero(epu8 a) { return _mm_testz_si128(a, a); }
  [gap_packages-4.14.0.p0]   [spkg-install]       |                                          ~~~~~~~~~~~~~~~^~~~~~
  [gap_packages-4.14.0.p0]   [spkg-install] /host/sage-manylinux_2_28_x86_64/include/libsemigroups/HPCombi/include/epu.hpp:205:58: error: cannot convert 'HPCombi::epu8' {aka '__vector(16) unsigned char'} to '__m128i'
  [gap_packages-4.14.0.p0]   [spkg-install]   205 | inline bool is_all_zero(epu8 a) { return _mm_testz_si128(a, a); }
  [gap_packages-4.14.0.p0]   [spkg-install]       |                                                          ^
  [gap_packages-4.14.0.p0]   [spkg-install]       |                                                          |
  [gap_packages-4.14.0.p0]   [spkg-install]       |                                                          HPCombi::epu8 {aka __vector(16) unsigned char}

https://github.com/passagemath/passagemath/actions/runs/16561885851/job/46833327219?pr=1342#step:13:15687

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 28, 2025

Still too big:

1 wheels produced in 3 minutes:
  passagemath_gap-10.6.1rc14-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl   246,866 kB

@mkoeppe mkoeppe mentioned this pull request Jul 28, 2025
Closed
@mkoeppe mkoeppe mentioned this pull request Aug 9, 2025
Merged
@mkoeppe mkoeppe force-pushed the passagemath-gap--include-gap_packages branch from dd9768b to 17def41 Compare August 9, 2025 06:47
@mkoeppe mkoeppe changed the title .github/workflows/dist.yml (wheels): Install gap_packages dist.yml (wheels): Install gap_packages, gap_pkg_jupyterkernel Aug 9, 2025
@mkoeppe mkoeppe mentioned this pull request Aug 9, 2025
Open
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 9, 2025 •
edited
Loading

Status quo:
passagemath_gap-10.6.2-cp310-cp310-manylinux2014_aarch64.manylinux_2_17_aarch64.manylinux_2_28_aarch64.whl (89.6 MB)

As of this commit:

  passagemath_gap-10.6.2-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl   109,478 kB
  passagemath_gap-10.6.2-cp310-cp310-macosx_13_0_x86_64.whl   98,449 kB
  passagemath_gap-10.6.2-cp310-cp310-macosx_14_0_arm64.whl   97,964 kB

Can spin out some more data packages (standard)

 14M	local/lib/gap/pkg/primgrp/data
 15M	local/lib/gap/pkg/factint/tables
 27M	local/lib/gap/pkg/smallgrp/
 35M	local/share/gap/grp

Also

 14M	local/lib/gap/pkg/irredsol/fp

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 9, 2025 

  passagemath_gap-10.6.2-cp310-cp310-macosx_14_0_arm64.whl   81,985 kB

@mkoeppe mkoeppe marked this pull request as ready for review August 9, 2025 19:02
@mkoeppe mkoeppe merged commit 45b82bb into main Aug 9, 2025
18 of 36 checks passed
@mkoeppe mkoeppe mentioned this pull request Aug 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkoeppe