Open
Conversation
mmimeault
previously approved these changes
Mar 22, 2017
Contributor
mmimeault
left a comment
mmimeault
left a comment
There was a problem hiding this comment.
Thank you very much, really appreciated.
hermanliang
suggested changes
Mar 23, 2017
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } |
Contributor
There was a problem hiding this comment.
ParseObject using key-value pair to manage data.
You need to use put(key, value)/get(key) inside your getter/setter. (That's why you can't retrieve data from the server.)
ex.
@ParseClassName("Room")
public class Room extends ParseObject {
public Room() {
}
public String getName() {
return getString("name");
}
public void setName(String name) {
put("name", name);
}
}
hermanliang
reviewed
Mar 23, 2017
|
|
||
| public class MainActivity extends AppCompatActivity { | ||
|
|
||
| String URL = "http://192.168.3.9:1337/parse/"; |
Contributor
There was a problem hiding this comment.
Variable named uppercase URL may be confused with the URL class.
String url
I recommend using lowercase to improve readability.
hermanliang
reviewed
Mar 23, 2017
| public void done(Room room, ParseException e) { | ||
| if (e != null) { | ||
| Log.d(DEBUG_TAG, "Found exception" + e); | ||
| e.printStackTrace(); |
Contributor
There was a problem hiding this comment.
Need deal with the exceptions?
hermanliang
reviewed
Mar 23, 2017
| // op=subscribe, className=Message, roomName=null, requestId=1, order=createdAt | ||
| ParseQuery<Message> parseQuery = ParseQuery.getQuery(Message.class); | ||
| // FIXME | ||
| parseQuery.whereEqualTo("roomName", "test"); |
Contributor
There was a problem hiding this comment.
should parseQuery.whereEqualTo("room", room);?
mmimeault
dismissed
their stale review
hermanliang has really good comments, waiting for edit first
Related to issue: parse-community#14 Currently only the conditions and class name are encoded: https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX/blob/master/Sources/ParseLiveQuery/Internal/QueryEncoder.swift
Patch OkHttp3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly for reference. Based on iOS Xcode app.