feat: Add revokeObjectURL functionality and enhance image processing with type handling

parlandin · parlandin · commit 4173ef91fcc4 · 2025-05-29T21:59:12.000-03:00
diff --git a/scripts/background.js b/scripts/background.js
@@ -48,6 +48,7 @@ const MESSAGE_ACTIONS = {
   SHOW_SUCCESS_TOAST: "showDownloadSuccessToast",
   SHOW_ERROR_TOAST: "showDownloadErrorToast",
   SHOW_LOADING_TOAST: "showLoadingToast",
+  DELETE_OBJECT_URL: "deleteObjectURL",
 };
 
 // ============================================================================
@@ -216,6 +217,12 @@ async function handleStorageChanges(changes) {
 // ============================================================================
 // EVENT HANDLERS
 // ============================================================================
+async function revokeObjectURL(url, tabId) {
+  browser.tabs.sendMessage(tabId, {
+    action: MESSAGE_ACTIONS.DELETE_OBJECT_URL,
+    message: { url },
+  });
+}
 
 async function handleContextMenuClick(info, tab) {
   const menuItemId = info.menuItemId;
@@ -232,8 +239,11 @@ async function handleContextMenuClick(info, tab) {
       return;
     }
 
-    const { url, fileExtension } = resolvedImage;
-    downloadImageToLocal(url, folderSuffix, fileExtension, tab?.id);
+    const { url, fileExtension, type } = resolvedImage;
+    await downloadImageToLocal(url, folderSuffix, fileExtension, tab?.id);
+    if (type == "blob" || type == "data") {
+      await revokeObjectURL(url, tab?.id);
+    }
     return;
   }
 
@@ -244,7 +254,10 @@ async function handleContextMenuClick(info, tab) {
       return;
     }
 
-    saveImageToDropbox(resolvedImage.url, tab?.id);
+    await saveImageToDropbox(resolvedImage.url, tab?.id);
+    if (resolvedImage.type === "blob" || resolvedImage.type === "data") {
+      await revokeObjectURL(resolvedImage.url, tab?.id);
+    }
     return;
   }
 }
diff --git a/scripts/content_script.js b/scripts/content_script.js
@@ -10,6 +10,7 @@ const MESSAGE_ACTIONS = {
   DOWNLOAD_IMAGE_AT_POSITION: "download-image",
   CONTEXT_MENU_POSITION: "context-menu-position",
   SHOW_LOADING_TOAST: "showLoadingToast",
+  DELETE_OBJECT_URL: "deleteObjectURL",
 };
 
 const TOAST_TYPES = {
@@ -445,6 +446,16 @@ async function handleDownloadImageMessage(message) {
   return createImageDownloadResponse(url, "image");
 }
 
+async function revokeObjectURL(data) {
+  const { message } = data;
+  if (!message || !message.url) {
+    return null;
+  }
+
+  URL.revokeObjectURL(message.url);
+  return null;
+}
+
 function isToastMessage(action) {
   return (
     action === MESSAGE_ACTIONS.SHOW_SUCCESS_TOAST ||
@@ -474,6 +485,9 @@ function handleRuntimeMessage(message, sender, sendResponse) {
     case MESSAGE_ACTIONS.DOWNLOAD_IMAGE_AT_POSITION:
       return handleDownloadImageMessage(message);
 
+    case MESSAGE_ACTIONS.DELETE_OBJECT_URL:
+      return revokeObjectURL(message);
+
     default:
       return undefined;
   }
@@ -499,8 +513,12 @@ function handleContextMenu(event) {
 // EVENT LISTENERS SETUP
 // ============================================================================
 function setupEventListeners() {
-  document.addEventListener("dblclick", handleDoubleClickEvent);
-  document.addEventListener("contextmenu", handleContextMenu);
+  document.addEventListener("dblclick", handleDoubleClickEvent, {
+    passive: true,
+  });
+  document.addEventListener("contextmenu", handleContextMenu, {
+    passive: true,
+  });
   browser.runtime.onMessage.addListener(handleRuntimeMessage);
 }
 
diff --git a/scripts/download.js b/scripts/download.js
@@ -86,19 +86,22 @@ async function processImageUrl(imageUrl, type, tabId, tab) {
       return {
         url: blobUrl,
         fileExtension: blobData.extension,
+        type: type,
       };
 
     case "data":
       const response = await browser.tabs.sendMessage(tabId, {
         action: "FETCH_DATA_URL",
         url: imageUrl,
+        type: type,
       });
 
       if (response.success) {
         const dataUrl = response.dataUrl;
         return {
           url: dataUrl,
           fileExtension: await getFileExtension(dataUrl),
+          type: type,
         };
       }
 
@@ -107,13 +110,15 @@ async function processImageUrl(imageUrl, type, tabId, tab) {
       return {
         url: absoluteUrl,
         fileExtension: await getFileExtension(absoluteUrl),
+        type: type,
       };
 
     case "http":
     default:
       return {
         url: imageUrl,
         fileExtension: await getFileExtension(imageUrl),
+        type: type,
       };
   }
 }
