ui: Handle undefined BigInt values properly#5961
Merged
Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 469 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 031288a. This comment will update as new commits are pushed. |
yomete
commented
Sep 18, 2025
| const handleSetInvert = (value: boolean): void => { | ||
| setInvertStack(value ? 'true' : ''); | ||
|
|
||
| resetFlameGraphState(); |
Contributor
Author
There was a problem hiding this comment.
Reset the flame graph expansion when inverting the call stack
brancz
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the null checks for
cumulativeColumnanddiffColumnvalues in bothFlameGraphNodes.tsxanduseVisibleNodes.tsto use!= nullinstead of!== null, ensuring undefined values are handled properly.It also fixes a memoization cache bug in
useVisibleNodesthat caused missing flame graph nodes when switching between data states/modifying the URL state, by addingtable.numRowsto the cache key.And lastly, I modified the invert call stack button in
InvertCallStack/index.tsxto reset the flame graph state when toggling.