ui: Properly handle multiple encodings for query expressions#5661
Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 439 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit b5e6b17. This comment will update as new commits are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps to handle query expressions that have been encoded multiple times and now breaking the app. It safely decodes strings that may have multiple levels of URL encoding with the
decodeMultipleEncodingsfunction.I've also added safegaurds to ensure that we're not unnecessarily encoding query expressions multiple times by doing all the encoding for query expressions in the
filterSuffixfunction.