area/ui: Add a popover menu to the AreaGraph component#5364
Merged
Conversation
yomete
changed the title
|
🤖 Meticulous spotted visual differences in 1 of 219 screens tested: view and approve differences detected. Meticulous simulated ~4 hours of user flows against your PR. Last updated for commit b54dff8. This comment will update as new commits are pushed. |
manojVivek
approved these changes
Dec 9, 2024
Contributor
manojVivek
left a comment
manojVivek
left a comment
There was a problem hiding this comment.
One minor change, looks great otherwise.
| <div className="flex gap-1 items-center"> | ||
| <div>Timestamp:</div> | ||
| <div className="text-gray-600 dark:text-gray-300"> | ||
| {formatDate(timestamp, timePattern(timezone), timezone)} |
Contributor
There was a problem hiding this comment.
I think it would make more sense to display the time with milliseconds precision here.
When the timeframe is tight, we'll have multiple points within a second and milliseconds precision would really help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.