Skip to content

remove unnecessary non-nil == nil check#5306

Merged
brancz merged 3 commits into
parca-dev:mainfrom
enfinyte:main
Dec 10, 2024
Merged

remove unnecessary non-nil == nil check#5306
brancz merged 3 commits into
parca-dev:mainfrom
enfinyte:main

Conversation

@vidurkhanal
Copy link
Copy Markdown
Contributor

the header == nil check is unnecessary. the header was established to be non nil from couple of LOC before the switch statements.

@vidurkhanal vidurkhanal requested a review from a team as a code owner November 20, 2024 04:56
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@brancz brancz merged commit 948987e into parca-dev:main Dec 10, 2024
@brancz
Copy link
Copy Markdown
Member

brancz commented Dec 10, 2024

Thank you!

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Dec 10, 2024

✅ Meticulous spotted zero visual differences across 210 screens tested: view results.

Meticulous simulated ~4 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 28a391f. This comment will update as new commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants