area/ui: Enhance regex filtering in SimpleMatchers component#5288
Merged
Conversation
|
✅ Meticulous spotted zero visual differences across 334 screens tested: view results. Meticulous simulated ~4 hours of user flows against this PR. Expected differences? Click here. Last updated for commit e5fcea9. This comment will update as new commits are pushed. |
metalmatze
approved these changes
Nov 11, 2024
Member
metalmatze
left a comment
metalmatze
left a comment
There was a problem hiding this comment.
Very, very nice!
That is exactly what I imagined. 🥳
Love the detail that the copy into the input field only works on regex selectors. 💯
Ship it! 🎉
Contributor
Author
awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following comments:
When clicking on a value in the dropdown I expect the selected value to be set as the value in the input of the dropdown. Further on, this is going to be helpful as I only need to adjust some parts of the values for the regex from prometheus-k8s-0 to prometheus-k8s-\d rather than still having to type the entire thing.
Something about the Add button still seems weird. It's still floating above the input text. (24s in the video). Can we have two vertical divs? One with the input and one below with the button? Then it'll always be below and never next or above the input.