Update Coursier default version to v2.1.24#22906
Conversation
|
@benjyw Can you review this when you have a chance? |
|
Thanks! If no one gets to this before then, I'll be more available for reviews once I finally bring home the Python 3.14 upgrade, hopefully this weekend or next week. |
| dependency_entry | ||
| entries.get((d.group, d.artifact, d.classifier)) | ||
| for d in entry.dependencies | ||
| # The dependency might not be present in the entries due to coursier bug: |
There was a problem hiding this comment.
I'm not yet confident that the issue has been fixed on the coursier side, just because the one example we had seems not to occur. Can we point to the coursier PR that truly fixes this?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for doing the digging! Looking at that change, it makes total sense that this fixes the issue. No need to link to this in the code (especially since the comment would have to say something like "we used to work around this Coursier bug here, and now we don't have to", which is hardly necessary). I just wanted us to be reasonably confident that this issue is indeed fixed.
|
I updated the PR summary and release notes, so I think the PR check should pass now |
|
Sorry for the back-and-forth on this. Lint, check, and test are all passing now on my machine. |
3 participants
Pick up the fix for this Coursier bug.
Running the reported cs command (
cs fetch --json-output-file example.json org.apache.hive:hive-exec:1.1.0 --exclude org.apache.calcite:calcite-avatica --exclude org.apache.calcite:calcite-core --exclude jdk.tools:jdk.tools) results in anexample.jsonfile where hive-exec depends on junit 4.11 which is present in the file as well with its own coord entry.