Repository navigation
[SITE-5428] check for SimpleSAML\Auth\Simple object before finding its autoloader (Attempt II) - #444
Merged
Merged
Conversation
… (re-apply) --------- Co-authored-by: David Dashifen Kees <dashifen@dashifen.com>
Check for both SimpleSAML\Auth\Simple (2.x) and SimpleSAML_Auth_Simple (1.18) before attempting to find and load the autoloader. This fixes the case where SimpleSAMLphp 1.18 is already autoloaded but the code only checked for the 2.x namespace class.
pwtyler
commented
Dec 18, 2025
| * @param string $path Path to autoloader | ||
| * @return void | ||
| */ | ||
| protected function maybe_log_error( $path = '' ) { |
Member
Author
There was a problem hiding this comment.
this is not a generic error wrapper, but an autoload error— method name should be more specific.
AnaisPantheor
self-requested a review
December 18, 2025 19:52
AnaisPantheor
changed the title
AnaisPantheor
approved these changes
Dec 19, 2025
pwtyler
commented
Dec 19, 2025
pwtyler
commented
Dec 19, 2025
AnaisPantheor
added a commit
that referenced
this pull request
Jan 8, 2026
#444) --------- Co-authored-by: David Dashifen Kees <dashifen@dashifen.com> Co-authored-by: Anais Gueyte <anaisgueyte@pantheon.io>
AnaisPantheor
added a commit
that referenced
this pull request
Jan 8, 2026
#444) --------- Co-authored-by: David Dashifen Kees <dashifen@dashifen.com> Co-authored-by: Anais Gueyte <anaisgueyte@pantheon.io>
AnaisPantheor
added a commit
that referenced
this pull request
Jan 9, 2026
#444) --------- Co-authored-by: David Dashifen Kees <dashifen@dashifen.com> Co-authored-by: Anais Gueyte <anaisgueyte@pantheon.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #414 was merged to
developwithout running all of its CI (coming from a fork) and still needed work. It was backed out in #443 and re-applied here to address with fixes for testing.From original PR: