Skip to content

Conversation

@jazzsequence
Copy link
Contributor

Release for 1.3.4

Notably, the changelog and versions in develop had not been updated. It's likely that we will want/need to merge this branch into develop as well as into main (for the release).

John Spellman and others added 11 commits December 20, 2022 08:58
[CMS-1141] Update images for lint and test-behat jobs
….0 (#229)

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix GPL license version

* add a fallback
if $session is not null but the ->get_data is this creates a PHP warning
It's possible this might escallate to a fatal in PHP 8+
Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/

* exclude short ternaries being disallowed
I fundamentally disagree with the guidance that they are "rarely used
correctly"
@jazzsequence jazzsequence requested a review from a team as a code owner February 7, 2023 19:50
@jazzsequence jazzsequence self-assigned this Feb 7, 2023
@jazzsequence jazzsequence requested a review from a team February 7, 2023 19:51
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jazzsequence jazzsequence merged commit 6afb1d2 into main Feb 7, 2023
@jazzsequence jazzsequence deleted the release-1.3.4 branch February 7, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants