Conversation
* multi-braceless statements
This changes:
```
if (1)
for (;;)
i +=
l
```
to:
```
if (1)
for (;;)
i +=
l
```
this will improve performance depending on the file. I will try and clean it a little
Give jsGlobalNodeObjects a higher priority that can therefore be targeted if desired.
makes a huge difference when not in a 'scope'. avoids checking the whole file * improve helper
Any issues with this? It doesn't rlly mean anything, just something to satisfy vim/dev
Fix jsFlowTypeCustom regex to allow dots
can otherwise be a object key
* improve end of line trim * Date
* skip comment #664 (comment)
Add support for "for await" (asynchronous iteration)
Collaborator
Author
|
I'll fix the conflict and merge later today or tomorrow |
Collaborator
Author
|
Can @amadeus or @BenoitZugmeyer or @tomxtobin confirm whether i resolved the conflict correctly? |
Collaborator
Author
|
I'm going to merge in an hour. Last chance syntax guys ! |
Contributor
|
You removed the line
|
Collaborator
Author
|
822dfe5 is the problem? |
Contributor
|
It seems so, yes. |
Contributor
|
I think my #660 is missing in there, as well? |
Collaborator
Author
|
#660 is in master |
Contributor
Whoops. Thanks! |
Collaborator
Author
|
No conflicts now, how does this look @BenoitZugmeyer ? |
Contributor
|
LGTM! thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's a good idea to get this out. I forget about this stuff being dev only
edit: One or two more commits I want to get in this