Merged
Conversation
Collaborator
|
Thanks for submitting the PR, good eye. Since NodeJS is so common, I am totally ok with adding certain important NodeJS keywords. Other NodeJS related stuff could always be added in a plugin as well. The If you can perhaps start an issue or a PR with the NodeJS things you'd like to see, that would be a good starting place for that discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionnal thoughts:
@Commentgroup tosyntax region jsComment start=/\/\// end=/$/ contains=jsCommentTodo,@Spell extend keepend? That way people can add their own comment-highlighting whitout hacking through the whole syntax.