Conversation
Adds support for string func names in objs classes
Collaborator
|
yea, i'm going to need to test some more though |
Collaborator
|
if you are ready to merge you don't need to wait on my pr since I do think i'll need a day or two |
Collaborator
Author
|
I'll wait for now, unless I see another issue regarding the issue that this fixes. |
Collaborator
|
tomorrow morning i'll merge my pr, after some more testing |
Fixing object string keys
Made the scoping of catch statements dependent on try.
Fix Promise Catch Method Calls
Collaborator
Author
|
Ok, this has some fairly important fixes. Is this good to go? |
Collaborator
|
i think so.the last few commits are big improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some quick but important fixes from our last release.
@bounceme I assume you probably want to get an indent fix or two in here as well?