Skip to content

ENH: Add CoW optimization to interpolate #51249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phofl merged 13 commits into from
Feb 10, 2023
Merged

ENH: Add CoW optimization to interpolate #51249

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2cef799
ENH: Implement CoW for interpolate
phofl Feb 7, 2023
26f3972
Fix and add first test
phofl Feb 7, 2023
27648c6
Add tests
phofl Feb 7, 2023
80c95de
Add tests
phofl Feb 7, 2023
d132161
ENH: Add CoW optimization to interpolate
phofl Feb 8, 2023
644af0c
Remove comment
phofl Feb 8, 2023
425f8f4
Fix
phofl Feb 8, 2023
3119c84
Fix
phofl Feb 8, 2023
58bffc9
Fix tests
phofl Feb 9, 2023
254de7d
Simplify
phofl Feb 9, 2023
30ac5f3
Simplify
phofl Feb 9, 2023
1e82658
Merge branch 'main' into cow_interp
phofl Feb 9, 2023
64b40ce
Update pandas/tests/copy_view/test_interp_fillna.py
phofl Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update pandas/tests/copy_view/test_interp_fillna.py 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
  • Loading branch information
@phofl @jorisvandenbossche
phofl and jorisvandenbossche authored Feb 10, 2023
commit 64b40cea80f470408fe809a7783f46ffc4308c71
2 changes: 1 addition & 1 deletion pandas/tests/copy_view/test_interp_fillna.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def test_interpolate_object_convert_no_op(using_copy_on_write):
arr_a = get_array(df, "a")
df.interpolate(method="pad", inplace=True)

# No CoW makes a copy, it should not!
# Now CoW makes a copy, it should not!
if using_copy_on_write:
assert df._mgr._has_no_reference(0)
assert np.shares_memory(arr_a, get_array(df, "a"))
Expand Down