Skip to content

Updated value_counts documentation and implementation and added single label subset test #50955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhshadrach merged 14 commits into from
Feb 20, 2023
Merged

Updated value_counts documentation and implementation and added single label subset test #50955

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
44c31db
first value_counts commit
tpackard1 Jan 24, 2023
c20e994
updated test_data_frame_value_counts_subset
tpackard1 Jan 24, 2023
da41988
updated subset docstring
tpackard1 Jan 28, 2023
efae1bf
Back to pre updated subset docstring commit
tpackard1 Jan 30, 2023
245526b
added integer column label test
tpackard1 Jan 30, 2023
e5f96b2
updated value_counts subset test
tpackard1 Jan 30, 2023
80d0576
parameterized tests and fixed implimentation for integers
tpackard1 Feb 1, 2023
b90811f
resolved conflict issues
tpackard1 Feb 6, 2023
ea3677e
Merge remote-tracking branch 'upstream/main' into update-value_counts
tpackard1 Feb 7, 2023
ff87dc8
fixed docstring
tpackard1 Feb 8, 2023
343a701
Merge remote-tracking branch 'upstream/main' into update-value_counts
tpackard1 Feb 8, 2023
a7f61c5
fixed test_data_frame_value_counts_subset
tpackard1 Feb 8, 2023
abed50a
Merge remote-tracking branch 'upstream/main' into update-value_counts
tpackard1 Feb 18, 2023
c3adbc9
updated whatsnew and docs
tpackard1 Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated test_data_frame_value_counts_subset
  • Loading branch information
@tpackard1
tpackard1 committed Jan 30, 2023
commit c20e994ea5e3e2c3e3426e65d4624282cbb59c79
4 changes: 1 addition & 3 deletions pandas/tests/frame/methods/test_value_counts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ def test_data_frame_value_counts_subset(nulls_fixture):
result = df.value_counts("first_name")
expected = pd.Series(
data=[2, 1, 1],
index=pd.MultiIndex.from_arrays(
[["John", "Anne", "Beth"]], names=["first_name"]
),
index=pd.Index(["John", "Anne", "Beth"], name="first_name"),
)

tm.assert_series_equal(result, expected)