Skip to content

Conversation

@rhshadrach
Copy link
Member

Built on #50846; just testing whether obj_with_exclusions is now the same as selected_obj with the exception of #50805

@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby labels Jan 19, 2023
@rhshadrach rhshadrach marked this pull request as draft January 19, 2023 22:16
@jbrockmendel
Copy link
Member

(Not having looked at the code) nice!

@jbrockmendel
Copy link
Member

Is this still viable?

@rhshadrach
Copy link
Member Author

Nope - closing.

@rhshadrach rhshadrach closed this Feb 8, 2023
@rhshadrach rhshadrach deleted the remove_obj_with_exclusions branch February 8, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Groupby Refactor Internal refactoring of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLN/DOC: _selected_obj vs _obj_with_exclusions

2 participants