Skip to content

Fix groupby-resample KeyError when resampling on Index and giving explicit list of columns. (1.5.x) #50841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
czroth wants to merge 4 commits into from
Closed

Fix groupby-resample KeyError when resampling on Index and giving explicit list of columns. (1.5.x) #50841

czroth wants to merge 4 commits into from

Conversation

@czroth
Copy link
Contributor

@czroth czroth commented Jan 18, 2023 •
edited
Loading

@czroth
Copy link
Contributor Author

czroth commented Jan 19, 2023

Pandas Devs:
I updated the 1.5.x branch with the fix. Please reply with instructions on if I should add the fix and test code to the main branch as well, or if you would like to do that. This is my first contribution to Pandas, so I'm unfamiliar with the workflow at this point.

@mroeschke
Copy link
Member

mroeschke commented Jan 19, 2023

PRs should generally always target the main branch. This bug fix should also target 2.0 and not 1.5.x as this doesn't appear like a regression per se

@czroth czroth changed the base branch from 1.5.x to main January 19, 2023 21:50
@czroth czroth changed the base branch from main to 1.5.x January 19, 2023 21:50
@czroth
Copy link
Contributor Author

czroth commented Jan 19, 2023

@mroeschke, I'll leave this PR open in case you also want to have the changes made to the 1.5.x branch. I'll also open a new PR (linked with this one) where I've applied the fix to the main branch and added to the whatsnew for v2.0

@czroth czroth changed the title Fix groupby-resample KeyError when resampling on Index and giving explicit list of columns. Fix groupby-resample KeyError when resampling on Index and giving explicit list of columns. (1.5.x) Jan 19, 2023
@czroth czroth mentioned this pull request Jan 19, 2023
Merged
5 tasks
@mroeschke
Copy link
Member

mroeschke commented Jan 19, 2023

We have a backporting bot that would take care of this (and this fix doesn't appear eligible for it) so will close this one

@mroeschke mroeschke closed this Jan 19, 2023
@czroth czroth deleted the 1.5.x branch January 27, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czroth @mroeschke