Skip to content

BUG: Fix memory leak in to_json for time objects #50794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 1 commit into from
Jan 18, 2023
Merged

BUG: Fix memory leak in to_json for time objects #50794

mroeschke merged 1 commit into from
Jan 18, 2023

Conversation

@lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jan 17, 2023 •
edited
Loading 

       before           after         ratio
     [579e0709]       [a0c41198]
     <main>           <fix-json-memleak>
-           73.7M            69.9M     0.95  io.json.ToJSONMem.peakmem_time

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@lithomas1 lithomas1 added Performance Memory or execution speed performance IO JSON read_json, to_json, json_normalize labels Jan 17, 2023
@jbrockmendel
Copy link
Member

jbrockmendel commented Jan 17, 2023

cc @WillAyd

@WillAyd
Copy link
Member

WillAyd commented Jan 17, 2023

Lgtm when green

@lithomas1 lithomas1 marked this pull request as ready for review January 17, 2023 20:15
@lithomas1 lithomas1 added this to the 2.0 milestone Jan 17, 2023
@mroeschke mroeschke merged commit 2f44dba into pandas-dev:main Jan 18, 2023
@mroeschke
Copy link
Member

mroeschke commented Jan 18, 2023

Thanks @lithomas1

@xmatthias xmatthias mentioned this pull request Jan 18, 2023
Merged
@lithomas1 lithomas1 deleted the fix-json-memleak branch January 18, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

IO JSON read_json, to_json, json_normalize Performance Memory or execution speed performance

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

BUG: Memory leak in json encoding for time related objects

4 participants

@lithomas1 @jbrockmendel @WillAyd @mroeschke