Skip to content

BUG: parsing mixed-offset Timestamps with errors='ignore' and no format raises #50586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 4 commits into from
Jan 6, 2023
Merged

BUG: parsing mixed-offset Timestamps with errors='ignore' and no format raises #50586

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d29eea
refactor and fix bug
Jan 5, 2023
a334a84
simplify
Jan 5, 2023
1a7d888
whatsnew notes
Jan 5, 2023
79e5cc9
Merge branch 'main' into ref-tslib
MarcoGorelli Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify
  • Loading branch information
MarcoGorelli committed Jan 5, 2023
commit a334a8412d23a63eff6562001a0eb638228b42a7
6 changes: 2 additions & 4 deletions pandas/_libs/tslib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,16 +614,14 @@ cpdef array_to_datetime(
else:
raise TypeError(f"{type(val)} is not convertible to datetime")

except (OutOfBoundsDatetime,) as ex:
except OutOfBoundsDatetime as ex:
ex.args = (f"{ex}, at position {i}",)
if is_coerce:
iresult[i] = NPY_NAT
continue
elif is_raise:
raise
if isinstance(ex, OutOfBoundsDatetime):
return ignore_errors_out_of_bounds_fallback(values), tz_out
return values, None
return ignore_errors_out_of_bounds_fallback(values), tz_out

except (TypeError, OverflowError, ValueError) as ex:
Copy link
Member Author

@MarcoGorelli MarcoGorelli Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currenly, OutOfBoundsDatetime is in a separate block. That's because of #50587

If it's OK, I'll address that in a separate PR, to not make the diff too big here

ex.args = (f"{ex}, at position {i}",)
Expand Down