Skip to content

ENH: improve error reporting for dup columns in merge_asof #50150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 2 commits into from
Dec 13, 2022
Merged

ENH: improve error reporting for dup columns in merge_asof #50150

mroeschke merged 2 commits into from
Dec 13, 2022
+18 −2

Conversation

@phofl
Copy link
Member

@phofl phofl commented Dec 9, 2022

@phofl phofl added the Error Reporting Incorrect or improved errors from pandas label Dec 9, 2022
@mroeschke mroeschke added this to the 2.0 milestone Dec 13, 2022
@mroeschke mroeschke merged commit 43bff73 into pandas-dev:main Dec 13, 2022
@mroeschke
Copy link
Member

mroeschke commented Dec 13, 2022

Thanks @phofl

@phofl phofl deleted the 50102 branch December 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Error Reporting Incorrect or improved errors from pandas

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

BUG: merge_asof with non-unique on, left_on, or right_on, raises AttributeError: 'DataFrame' object has no attribute 'dtype'

2 participants

@phofl @mroeschke