Bug: Incorrect IntervalIndex.is_overlapping #49933
Conversation
Hikipeko
changed the title
pandas/_libs/intervaltree.pxi.in
Outdated
| """ | ||
| if self._left_sorter is None: | ||
| self._left_sorter = np.argsort(self.left) | ||
| left_right = np.asarray([(self.left[i], self.right[i]) for i in range(0, |
There was a problem hiding this comment.
this looks likely to be non-performant. can we maybe check for uniqueness and only do this in the non-unique case?
There was a problem hiding this comment.
Sounds like a more decent solution. Actually, I'm a first-time contributor here, so I'm wondering what to do next. Do I have to close the PR?
There was a problem hiding this comment.
You can push a new commit to update your pull request with the changes
There was a problem hiding this comment.
i think elsewhere in the file we use np.lexsort([self.left, self.right]) which should be similar to this
There was a problem hiding this comment.
Sound like a much better way for sorting, and I have made these changes in my latest commit.
|
Also, is |
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Could you remove pandas/_libs/intervaltree.pxi.pdf?
|
@mroeschke Fixed. Edit: Strangely it fails the "Python Dev / actions-311-dev (macOS-latest) (pull_request)" integration test. |
I've removed this file, is there any thing I've to do now? |
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
LGTM. Merge when ready @jbrockmendel
|
thanks @Hikipeko |
3 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.