API: various .value_counts() result in different names / indices #49912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 25, 2022 09:01
MarcoGorelli
changed the title
MarcoGorelli
changed the title
3 tasks
mroeschke
added
API Design
Algos
mroeschke
reviewed
Dec 5, 2022
doc/source/whatsnew/v2.0.0.rst
Outdated
| .. _whatsnew_200.api_breaking.value_counts: | ||
|
|
||
| Value counts behaviour change |
Member
There was a problem hiding this comment.
Something more specific like ``value_counts`` sets the resulting name to ``"count"`` would be good
mroeschke
reviewed
Dec 5, 2022
doc/source/whatsnew/v2.0.0.rst
Outdated
| confusion when resetting the index, and the column names would not correspond with the | ||
| column values. | ||
| Now, the result name will be ``'count'`` (or ``'proportion'`` if ``normalize=True`` was passed), | ||
| and the index will be named after the original object. |
Member
There was a problem hiding this comment.
Could you add the issue number here?
jbrockmendel
reviewed
Dec 5, 2022
jbrockmendel
reviewed
Dec 5, 2022
Member
Author
|
Good point on |
Member
Author
|
gentle ping 😄 do we still want to make this change? |
Member
Author
|
cheers - @jbrockmendel any further comments? |
jbrockmendel
approved these changes
Feb 1, 2023
Member
jbrockmendel
left a comment
jbrockmendel
left a comment
There was a problem hiding this comment.
LGTM thanks for sticking with this
Member
Author
|
thanks for your reviews, much appreciated! merging then, before more conflicts come in |
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.screenshot of whatsnewnote: