BUG: MultiIndex.join losing dtype #49877
Merged
+74
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/source/whatsnew/v2.0.0.rst
mroeschke
reviewed
Nov 28, 2022
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Looks good. Could you also add a combine_first unit test from the original issue as a smoke test? #49830 (comment)
Member
Author
|
Added the test |
mroeschke
reviewed
Nov 29, 2022
mroeschke
approved these changes
Nov 29, 2022
Member
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combine_first()coerces toobjectforMultiIndexand all-nan index columns #49830 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.#Sits on top of #49847