DEPR: make to_datetime('now') match Timestamp('now') #45104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Dec 29, 2021
jbrockmendel
commented
- closes Timestamp("now") should match to_datetime("now") #18705
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
reviewed
Dec 29, 2021
doc/source/whatsnew/v1.4.0.rst
Outdated
| - Deprecated passing non boolean argument to sort in :func:`concat` (:issue:`41518`) | ||
| - Deprecated passing arguments as positional for :func:`read_fwf` other than ``filepath_or_buffer`` (:issue:`41485`): | ||
| - Deprecated passing ``skipna=None`` for :meth:`DataFrame.mad` and :meth:`Series.mad`, pass ``skipna=True`` instead (:issue:`44580`) | ||
| - Deprecated the behavior of :func:`to_datetime` with the string "now" with ``utc=False``; in a future version this will match ``Timestamp("now")``, which in turn matches :meth:`Timestamp.now` (:issue:`18705`) |
Member
There was a problem hiding this comment.
Maybe good to mention here that Timestamp("now")/Timestamp.now returns local time.
mroeschke
reviewed
Dec 29, 2021
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
One comment otherwise LGTM.
mroeschke
added
Deprecate
Contributor
|
@jbrockmendel small comment and a rebase and can get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.