Skip to content

Conversation

@klssmith
Copy link
Contributor

Added https://github.com/pre-commit/pre-commit-hooks#debug-statements as a pre-commit hook.

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Katie!

Leaving open for a bit in case anyone else has comments, but it should be good to go


For context, this is something I'd suggested here: MarcoGorelli/pyladieslondon-sprints#38 . I keep accidentally committing breakpoints, and we're already using pre-commit-hooks, so this'll be a really light addition

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone May 15, 2021
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label May 15, 2021
@MarcoGorelli MarcoGorelli merged commit b2a36bd into pandas-dev:master May 16, 2021
@MarcoGorelli
Copy link
Member

Thanks @klssmith !

@klssmith klssmith deleted the debug-statement-pre-commit branch May 16, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants