Skip to content

Deprecate suffixes in merge producing duplicate columns #40991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 5 commits into from
Apr 20, 2021
Merged

Deprecate suffixes in merge producing duplicate columns #40991

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd27c50
Deprecate suffixes in merge producing duplicate columns
phofl Apr 16, 2021
5192220
Adjust warning
phofl Apr 16, 2021
6994f3b
Add future warning
phofl Apr 17, 2021
a35f669
Do not check stacklevel
phofl Apr 17, 2021
7c83dd9
Add test and clarify comments
phofl Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add future warning
  • Loading branch information
@phofl
phofl committed Apr 17, 2021
commit 6994f3b3a47cc82120f56a8f63ab4e790f09a0cc
3 changes: 2 additions & 1 deletion pandas/tests/reshape/merge/test_join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,8 @@ def test_join_dups(self):
dta = x.merge(y, left_index=True, right_index=True).merge(
z, left_index=True, right_index=True, how="outer"
)
dta = dta.merge(w, left_index=True, right_index=True)
with tm.assert_produces_warning(FutureWarning):
dta = dta.merge(w, left_index=True, right_index=True)
expected = concat([x, y, z, w], axis=1)
expected.columns = ["x_x", "y_x", "x_y", "y_y", "x_x", "y_x", "x_y", "y_y"]
tm.assert_frame_equal(dta, expected)
Expand Down