PERF: JoinUnit.is_na #36312
Merged
PERF: JoinUnit.is_na #36312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 12, 2020
| inf_as_na = get_option(key) | ||
| globals()["_isna"] = partial(_isna, inf_as_na=inf_as_na) | ||
| if inf_as_na: | ||
| globals()["nan_checker"] = lambda x: ~np.isfinite(x) |
Contributor
There was a problem hiding this comment.
don't do it like this
use the global keyword
Member
Author
There was a problem hiding this comment.
this is the pattern we already use a few lines up
Contributor
There was a problem hiding this comment.
really? ok for here, but we really should just use the global keyword as this is the purpose.
jreback
added
Missing-data
jreback
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This along with #36309 gets #34683 to performance parity with master.