Skip to content

CLN: Removed unreached else block GH33478 #35086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Jul 2, 2020
Merged

CLN: Removed unreached else block GH33478 #35086

jreback merged 2 commits into from
Jul 2, 2020

Conversation

@FollowTheProcess
Copy link
Contributor

@FollowTheProcess FollowTheProcess commented Jul 1, 2020 •
edited
Loading

Unreached else block in method _wrap_applied_output was removed.

Local tests passed before and after change

@FollowTheProcess
CLN: Removed unreached else block GH33478
9f00d60 
Unreached else block in method _wrap_applied_output was removed.

Local tests passed before and after change.
MarcoGorelli
MarcoGorelli reviewed Jul 1, 2020
View reviewed changes
pandas/core/groupby/generic.py
# of columns
return self.obj._constructor_sliced(values, index=key_index)

else:
Copy link
Member

@MarcoGorelli MarcoGorelli Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FollowTheProcess - while you're here, can you change the elif in line 1221 to else?

Copy link
Contributor Author

@FollowTheProcess FollowTheProcess Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry yep, will do this and the xref now

Copy link
Contributor Author

@FollowTheProcess FollowTheProcess Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's now done :) Thanks for helping me contribute (in an albeit microscopic way) the contributing docs made it super easy as a newbie. I hope to be able to contribute more as I learn more.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jul 1, 2020

closes #33478 (Not fully closed, this addresses 1 part)

Can you change "closes" to "xref"?

@FollowTheProcess
CLN GH33478 Correct elif to else in _wrap_applied_output.
49f824f 
Related to previous removal of unreached else block.
Removal left an out of place elif, replaced with else.

Local tests pass before/after
@MarcoGorelli MarcoGorelli self-requested a review July 1, 2020 20:13
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jul 1, 2020

The Windows py37_np18 shows a failure (pandas/tests/base/test_unique.py::test_unique_bad_unicode[idx_or_series_w_bad_unicode0]), although if I check out your pull request and run it myself it passes (also, none of the functions in pandas/tests/base/test_unique.py hit this code path), so am pretty sure the CI failure is unrelated

@FollowTheProcess
Copy link
Contributor Author

FollowTheProcess commented Jul 1, 2020

Oh, weird! I ran the full test suite (test_fast.sh) before committing and no failures for me either. Let me know if you need me to do anything else

@jreback jreback added this to the 1.1 milestone Jul 2, 2020
@jreback jreback merged commit c23228c into pandas-dev:master Jul 2, 2020
@jreback
Copy link
Contributor

jreback commented Jul 2, 2020

thanks @FollowTheProcess

@FollowTheProcess
Copy link
Contributor Author

FollowTheProcess commented Jul 2, 2020

Thanks both for the help. I hope to contribute more in the future!

@FollowTheProcess FollowTheProcess deleted the remove-unreachable-code branch July 5, 2020 06:46
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 15, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

Assignees

No one assigned

Labels

Clean Groupby

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@FollowTheProcess @MarcoGorelli @jreback @simonjayhawkins