REF: handling of max_colwidth parameter #25977
Conversation
|
can you merge master and update |
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
looks good, can you add a whatsnew note
| When formatting an Index subclass | ||
| (e.g. IntervalIndex._format_native_types), we don't want the | ||
| leading space since it should be left-aligned. | ||
| max_colwidth: False, int or None, optional, default None |
There was a problem hiding this comment.
can you add a versionadded tag
There was a problem hiding this comment.
not a public function. have added anyway.
|
@simonjayhawkins can you rebase and update when possible |
|
@simonjayhawkins whats the status of this? |
still need to do a precursor. checks were passing and i don't think they should have been. so holding as draft unless you'd rather it be closed for now.
comments addressed.
this should be a pure refactor. no whatsnew needed? |
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
looks fine. small comments.
|
|
||
| def _format_col(self, i: int): | ||
| """ | ||
| Calls `format_array` for column `i` of truncated DataFrame with |
There was a problem hiding this comment.
can you say positional column i
| * int: the maximum width of strings | ||
| * None: use display.max_colwidth setting | ||
| .. versionadded:: 1.0 |
There was a problem hiding this comment.
can just remove the versionadded (or make it 0.25.0)
|
@simonjayhawkins is this still active? |
|
can close for now. |
3 participants
git diff upstream/master -u -- "*.py" | flake8 --diffthis would be a precursor to fixes for #7059, #9784 and #6491.
getting the display.max_colwidth value is moved from
_make_fixed_widthtoformat_arrayto be consistent with the handling of thecolumn_space,float_formatandprecisiondisplay options.the PR also includes refactoring of the prior fix to
to_html#24841_format_colis moved fromDataFrameFormattertoTableFormatterto make it available toHTMLFormatterandNotebookFormatter.at the moment
_make_fixed_widthis called byformat_array, but also by_to_str_columnsand_get_formatted_index._to_str_columnsis not an issue because the calls are preceded to calls toformat_arrayIMO
_get_formatted_indexneeds to be refactored to callformat_arraydirectly and probably some additional tests as a precursor to this PR.thoughts?
cc @TomAugspurger