unrelated changes removed

ShisuiUzumaki · ShisuiUzumaki · commit e1a297308e7e · 2022-12-15T19:40:29.000+05:00
diff --git a/doc/source/whatsnew/v2.0.0.rst b/doc/source/whatsnew/v2.0.0.rst
@@ -491,7 +491,8 @@ Other API changes
 
 Deprecations
 ~~~~~~~~~~~~
-- Deprecated argument ``infer_datetime_format`` in :func:`to_datetime` and :func:`read_csv`, as a strict version of it is now the default (:issue:`48621`)
+
+- :meth:`Index.is_categorical` has been deprecated. Use :func:`pandas.api.types.is_categorical_dtype` instead (:issue:`50042`)
 
 .. ---------------------------------------------------------------------------
 
diff --git a/pandas/core/indexes/base.py b/pandas/core/indexes/base.py
@@ -2238,7 +2238,7 @@ def is_integer(self) -> bool:
         is_floating : Check if the Index is a floating type.
         is_numeric : Check if the Index only consists of numeric data.
         is_object : Check if the Index is of the object dtype.
-        is_categorical : Check if the Index holds categorical data.
+        is_categorical : Check if the Index holds categorical data (deprecated).
         is_interval : Check if the Index holds Interval objects.
 
         Examples
@@ -2277,7 +2277,7 @@ def is_floating(self) -> bool:
         is_integer : Check if the Index only consists of integers.
         is_numeric : Check if the Index only consists of numeric data.
         is_object : Check if the Index is of the object dtype.
-        is_categorical : Check if the Index holds categorical data.
+        is_categorical : Check if the Index holds categorical data (deprecated).
         is_interval : Check if the Index holds Interval objects.
 
         Examples
@@ -2316,7 +2316,7 @@ def is_numeric(self) -> bool:
         is_integer : Check if the Index only consists of integers.
         is_floating : Check if the Index is a floating type.
         is_object : Check if the Index is of the object dtype.
-        is_categorical : Check if the Index holds categorical data.
+        is_categorical : Check if the Index holds categorical data (deprecated).
         is_interval : Check if the Index holds Interval objects.
 
         Examples
@@ -2359,7 +2359,7 @@ def is_object(self) -> bool:
         is_integer : Check if the Index only consists of integers.
         is_floating : Check if the Index is a floating type.
         is_numeric : Check if the Index only consists of numeric data.
-        is_categorical : Check if the Index holds categorical data.
+        is_categorical : Check if the Index holds categorical data (deprecated).
         is_interval : Check if the Index holds Interval objects.
 
         Examples
@@ -2388,6 +2388,9 @@ def is_categorical(self) -> bool:
         """
         Check if the Index holds categorical data.
 
+        .. deprecated:: 2.0.0
+              Use :meth:`pandas.api.types.is_categorical_dtype` instead.
+
         Returns
         -------
         bool
@@ -2424,6 +2427,12 @@ def is_categorical(self) -> bool:
         >>> s.index.is_categorical()
         False
         """
+        warnings.warn(
+            f"{type(self).__name__}.is_categorical is deprecated."
+            "Use pandas.api.types.is_categorical_dtype instead",
+            FutureWarning,
+            stacklevel=find_stack_level(),
+        )
         return self.inferred_type in ["categorical"]
 
     @final
@@ -2444,7 +2453,7 @@ def is_interval(self) -> bool:
         is_floating : Check if the Index is a floating type.
         is_numeric : Check if the Index only consists of numeric data.
         is_object : Check if the Index is of the object dtype.
-        is_categorical : Check if the Index holds categorical data.
+        is_categorical : Check if the Index holds categorical data (deprecated).
 
         Examples
         --------
@@ -5014,7 +5023,11 @@ def _can_hold_identifiers_and_holds_name(self, name) -> bool:
 
         https://github.com/pandas-dev/pandas/issues/19764
         """
-        if self.is_object() or is_string_dtype(self.dtype) or self.is_categorical():
+        if (
+            self.is_object()
+            or is_string_dtype(self.dtype)
+            or is_categorical_dtype(self)
+        ):
             return name in self
         return False
 
diff --git a/pandas/tests/indexes/common.py b/pandas/tests/indexes/common.py
@@ -795,6 +795,12 @@ def test_inv(self, simple_index):
             with pytest.raises(TypeError, match=msg):
                 ~Series(idx)
 
+    def test_is_categorical_is_deprecated(self, simple_index):
+        # GH50042
+        idx = simple_index
+        with tm.assert_produces_warning(FutureWarning):
+            idx.is_categorical()
+
 
 class NumericBase(Base):
     """
